[Xen-devel] [Qemu-devel] [PATCH v7 12/42] hw/s390x: Hard code size with MO_{8|16|32|64}

[<tony.nguyen@xxxxxx>]

Temporarily no-op size_memop was introduced to aid the conversion of

memory_region_dispatch_{read|write} operand "unsigned size" into

"MemOp op".

Now size_memop is implemented, again hard coded size but with

MO_{8|16|32|64}. This is more expressive and avoids size_memop calls.

Signed-off-by: Tony Nguyen <tony.nguyen@xxxxxx>

Reviewed-by: Richard Henderson <richard.henderson@xxxxxxxxxx>

Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>

---

 hw/s390x/s390-pci-inst.c | 3 +--

 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c

index 0c958fc..0e92a37 100644

--- a/hw/s390x/s390-pci-inst.c

+++ b/hw/s390x/s390-pci-inst.c

@@ -782,8 +782,7 @@ int pcistb_service_call(S390CPU *cpu, uint8_t r1, uint8_t r3, uint64_t gaddr,

     for (i = 0; i < len / 8; i++) {

         result = memory_region_dispatch_write(mr, offset + i * 8,

                                               ldq_p(buffer + i * 8),

-                                              size_memop(8),

-                                              MEMTXATTRS_UNSPECIFIED);

+                                              MO_64, MEMTXATTRS_UNSPECIFIED);

         if (result != MEMTX_OK) {

             s390_program_interrupt(env, PGM_OPERAND, 6, ra);

             return 0;

-- 

1.8.3.1

​

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel