Re: [Xen-devel] [PATCH v3 09/28] xen/arm32: head: Mark the end of subroutines with ENDPROC

[Julien Grall <julien.grall@xxxxxxx>]

On 12/08/2019 18:30, Julien Grall wrote:
> putn() and puts() are two subroutines. Add ENDPROC for the benefits of
> static analysis tools and the reader.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> Acked-by: Stefano Stabellini <sstabllini@xxxxxxxxxx>
Hmmm, I made a typo in Stefano's e-mail address. I can fix it on commit message 
(or next version).
Cheers,

> ---
>      Changes in v3:
>          - Add Stefano's acked-by
>
>      Changes in v2:
>          - Patch added
> ---
>   xen/arch/arm/arm32/head.S | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
> index 99f4af18d8..8b4c8a4714 100644
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -518,6 +518,7 @@ puts:
>           moveq pc, lr
>           early_uart_transmit r11, r1
>           b puts
> +ENDPROC(puts)
>   
>   /*
>    * Print a 32-bit number in hex.  Specific to the PL011 UART.
> @@ -537,6 +538,7 @@ putn:
>           subs  r3, r3, #1
>           bne   1b
>           mov   pc, lr
> +ENDPROC(putn)
>   
>   hex:    .ascii "0123456789abcdef"
>           .align 2
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel