Re: [Xen-devel] [PATCH v2 1/2] x86: define a few selector values

[Jan Beulich <jbeulich@xxxxxxxx>]

On 09.08.2019 13:50, Andrew Cooper wrote:
> On 09/08/2019 11:38, Jan Beulich wrote:
> > --- a/xen/include/asm-x86/desc.h
> > +++ b/xen/include/asm-x86/desc.h
> > @@ -36,6 +36,10 @@
> >   #define LDT_ENTRY (TSS_ENTRY + 2)
> >   #define PER_CPU_GDT_ENTRY (LDT_ENTRY + 2)
> >   
> > +#define TSS_SELECTOR         (TSS_ENTRY << 3)
> > +#define LDT_SELECTOR         (LDT_ENTRY << 3)
> > +#define PER_CPU_GDT_SELECTOR (PER_CPU_GDT_ENTRY << 3)
> Thinking about it, now would be an excellent time to remove the GDT
> infix from PER_CPU_GDT_{ENTRY,SELECTOR}.
>
> Looking at the resulting diff, there are only 3 extra hunks on top of
> this patch to perform the rename.
>
> Preferably with this done, Reviewed-by: Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>
I'm okay with dropping it from the new selector constant,
since "selector" can't really be mistaken. For "entry" though
I think this isn't clear enough without "GDT". (This is less
for a problem with TSS_ENTRY and LDT_ENTRY, as their prefixes
make clear these are GDT entities.)

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel