Re: [Xen-devel] [PATCH 2/4] xen: add new CONFIG_SPINLOCK_DEBUG option

[Juergen Gross <jgross@xxxxxxxx>]

On 08.08.19 09:35, Jan Beulich wrote:
> On 08.08.2019 09:23, Juergen Gross wrote:
> > On 08.08.19 08:34, Jan Beulich wrote:
> > > On 07.08.2019 16:31, Juergen Gross wrote:
> > > > --- a/xen/Kconfig.debug
> > > > +++ b/xen/Kconfig.debug
> > > > @@ -44,6 +44,13 @@ config COVERAGE
> > > >          If unsure, say N here.
> > > > +config SPINLOCK_DEBUG
> > > > +    bool "Spinlock debugging"
> > > > +    default DEBUG
> > > > +    ---help---
> > > > +      Enable debugging features of spinlock handling.  Some additional
> > > > +          checks will be performed when acquiring and releasing locks.
> > > > +
> > > >    config LOCK_PROFILE
> > > While the pre-existing LOCK_PROFILE suggests the opposite, I'd
> > > still like to propose that we uniformly name all debugging
> > > options CONFIG_DEBUG_* (rather than having the DEBUG at the
> > > end). Thoughts?
> > Fine with me. I can rename the LOCK_PROFILE option in patch 4 as I'm
> > touching it anyway.
> One more thing: Perhaps it would better be DEBUG_LOCK (i.e.
> without "SPIN") or DEBUG_LOCKS, to also allow it to cover r/w
> locks, should anyone want to instrument them as well.
Yes. I'll switch to DEBUG_LOCKS.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel