[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] EFI: add efi=mapbs option and parse efi= early
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Thu, 8 Aug 2019 07:38:30 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PLAI4nCbQnK5Guae3Q+DYY1GaUuMvqGApWfG62rCYDk=; b=mkKJzGpuE+s9RRkfVw4P3JCKCgdFenrTg/J3puW9PUscMLEtvNnkDpnc5PSycoLoN9pGdv7DmLQFdE9v8uptP0SV6pEFGNJSAiPac57NKDrzNN2i4gFH2AkEznlXwGI9Bsrl8OtDLHFgrTPGdKOx//lSLdYoTOkTZSrQjJEqOuJ5+QXFp+1hS8wJTrg4Y7xWS0MLsf8VoS36VDPn62Ivod/WuRU/Jhm7b2c67U1Fq+MeNLvAekqH9sb3dYll4qwRndsf/YtyjQs808X6y33lcMTacX+rtXS90eGRK7qPjGAnca4PmG/tkWs/zk+CkmVGsUB1D3RggGeJVDxggZbtsw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gx9F8vLJ28PJVu/fAutH4RRxdoKYRwxpdG+HjIhu1hCPwG+INEtcUa3wb5pnvCBRvPMB4pHKa/lE9R6xsaoj+GN5eVxsEOS9D6tEOoPefy1Weaob4SCXK+GGTflPY/bja8o1mjCirZjvq+zrdJdgI4u++K6EJwX+iqa9HWIbtPJLbnvjh1tydJWMEirMC+o4R8FNTcgsfXJL/bUz97uLMUirl7SLhilX7/BA09nRSi2PNVGhPpE1A//aDDLV3LWERWXYBTlbLfCOP3P+QId9lBrMze051oWsmA6n0i+kyyAMCve1KjManabbqe7E4qWEg/bx7QrfopxdrCctWz9fpA==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 08 Aug 2019 07:39:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVTYDiJDDJv46naU6f+B83HbCEaabwbBnJgABxbAA=
- Thread-topic: [PATCH] EFI: add efi=mapbs option and parse efi= early
On 08.08.2019 02:52, Marek Marczykowski-Górecki wrote:
>> --- a/xen/arch/x86/efi/efi-boot.h
>> +++ b/xen/arch/x86/efi/efi-boot.h
>> @@ -315,8 +315,10 @@ static void __init efi_arch_handle_cmdline(CHAR16
>> *image_name,
>> name.s = "xen";
>> place_string(&mbi.cmdline, name.s);
>>
>> - if ( mbi.cmdline )
>> + if ( mbi.cmdline ) {
>> mbi.flags |= MBI_CMDLINE;
>> + efi_early_parse_cmdline(mbi.cmdline);
>
> Compiler complains here, because mbi.cmdline is u32 (int vs pointer, and
> also a different size). What is the proper way to make compiler happy
> here? "(const char *)(uint64_t)" doesn't seems right.
Well, if the conversion to a pointer is correct here (i.e.
the specified address has a mapping), then
(const char*)(unsigned long) would be the canonical way to
go; using uintptr_t would also be an option, but we make
pretty little use of it.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
