[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 3/4] xen: print lock profile info in panic()
- To: Juergen Gross <JGross@xxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Thu, 8 Aug 2019 07:09:00 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=imu03eqnxs/tH08Tthf1skaCqOwPCRy9ni+BOAlkAv0=; b=TQFewt/XIeG6u0xf9y9R3mHj4rwzq+nDE6zZz/fCIFXq+VjyX3/UyTuXGPt5GkuSeVo49ZUp3wQMhV0F4YJtkWFiRCK3w7l4R1FaOpo0/R/SptnLdy630U3BjvxmT5izcWc97GjLZwDcmei/fwpWmkp5ZIaGAJpjTqsCXvtkwd3SIoG+D30KiKyPZQ9zHg/orm2yaqZomsBL496kzceRLXFJKQR77rWDv+zTyxgVhoxZqxMKeI8CEE1EkVh2s860+D5Vicq8vsxtR9RcLDpipZM7FiBJNIxQW/nx8VvYjgcdTm+cqecPswYRrHpzWndiecsoKCSu/QJdY6FzdMIO6Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pg04ZYdF+uaB8GX6gFI2gWXtUo3iGJEhIpZK6a7FxQUHxKYIvv9vG9mYVc+7obe7RnE0AJ7jU7OCVyAtS39qLP16eMklEg5YCzqpxkvqAsidno8GIbKDgS5YWGNz3lqk6HBPGq8OJh/WLwdLJVAfKf5Ws33CP4tgDrBUPHdKrU1cnfQi/pt+GwtNvYLH5XXxq2kjNUPmI1f1cpZ5qLrGrAZ9MsMc6dga+Y6Sz4mdYk/m+Hr8Wy2EjgeWwvfxBFq7f67EwW/wVNh/UU9JVeDRi4ghqOwvE2+ykGJ03RJGxTFoDbvWYWONcSJFGzNOUxbbmbOPRZt+aqk7mbDEmKKulw==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 08 Aug 2019 07:13:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVTSzY4tguuixAZkiEjkiM0DHSHqbw1e8A
- Thread-topic: [PATCH 3/4] xen: print lock profile info in panic()
On 07.08.2019 16:31, Juergen Gross wrote:
> --- a/xen/Kconfig.debug
> +++ b/xen/Kconfig.debug
> @@ -53,6 +53,7 @@ config SPINLOCK_DEBUG
>
> config LOCK_PROFILE
> bool "Lock Profiling"
> + select SPINLOCK_DEBUG
> ---help---
> Lock profiling allows you to see how often locks are taken and
> blocked.
> You can use serial console to print (and reset) using 'l' and 'L'
In which case, for sensible user experience, the selected
option should come after this one. The way it is now afaict
there'll be a prompt for SPINLOCK_DEBUG, the user may say
"no", just to find that because of saying "yes" here it'll
be turned on anyway. Whereas with switched ordering there'll
be no prompt for the debug option at all (again afaict) if
the profiling option was set to "yes".
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
