[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [Qemu-devel] [PATCH v6 20/26] memory: Access MemoryRegion with endianness
- To: tony.nguyen@xxxxxx, qemu-devel@xxxxxxxxxx
- From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
- Date: Wed, 7 Aug 2019 12:27:43 +0200
- Cc: fam@xxxxxxxxxx, peter.maydell@xxxxxxxxxx, walling@xxxxxxxxxxxxx, cohuck@xxxxxxxxxx, sagark@xxxxxxxxxxxxxxxxx, david@xxxxxxxxxx, jasowang@xxxxxxxxxx, palmer@xxxxxxxxxx, mark.cave-ayland@xxxxxxxxxxxx, i.mitsyanko@xxxxxxxxx, keith.busch@xxxxxxxxx, jcmvbkbc@xxxxxxxxx, frederic.konrad@xxxxxxxxxxx, dmitry.fleytman@xxxxxxxxx, kraxel@xxxxxxxxxx, edgar.iglesias@xxxxxxxxx, gxt@xxxxxxxxxxxxxxx, pburton@xxxxxxxxxxxx, xiaoguangrong.eric@xxxxxxxxx, peter.chubb@xxxxxxxxxxxx, philmd@xxxxxxxxxx, robh@xxxxxxxxxx, hare@xxxxxxxx, sstabellini@xxxxxxxxxx, berto@xxxxxxxxxx, chouteau@xxxxxxxxxxx, qemu-block@xxxxxxxxxx, arikalo@xxxxxxxxxxxx, jslaby@xxxxxxx, deller@xxxxxx, mst@xxxxxxxxxx, magnus.damm@xxxxxxxxx, jcd@xxxxxxxxxxxxxxx, pasic@xxxxxxxxxxxxx, borntraeger@xxxxxxxxxx, mreitz@xxxxxxxxxx, hpoussin@xxxxxxxxxxx, joel@xxxxxxxxx, anthony.perard@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, david@xxxxxxxxxxxxxxxxxxxxx, lersek@xxxxxxxxxx, green@xxxxxxxxxxxxxx, atar4qemu@xxxxxxxxx, antonynpavlov@xxxxxxxxx, marex@xxxxxxx, jiri@xxxxxxxxxxx, ehabkost@xxxxxxxxxx, minyard@xxxxxxx, qemu-s390x@xxxxxxxxxx, sw@xxxxxxxxxxx, alistair@xxxxxxxxxxxxx, yuval.shaia@xxxxxxxxxx, b.galvani@xxxxxxxxx, eric.auger@xxxxxxxxxx, alex.williamson@xxxxxxxxxx, qemu-arm@xxxxxxxxxx, jan.kiszka@xxxxxx, clg@xxxxxxxx, stefanha@xxxxxxxxxx, marcandre.lureau@xxxxxxxxxx, shorne@xxxxxxxxx, jsnow@xxxxxxxxxx, rth@xxxxxxxxxxx, kwolf@xxxxxxxxxx, qemu-riscv@xxxxxxxxxx, proljc@xxxxxxxxx, andrew@xxxxxxxx, kbastian@xxxxxxxxxxxxxxxxxxxxx, crwulff@xxxxxxxxx, laurent@xxxxxxxxx, Andrew.Baumann@xxxxxxxxxxxxx, sundeep.lkml@xxxxxxxxx, andrew.smirnov@xxxxxxxxx, michael@xxxxxxxx, paul.durrant@xxxxxxxxxx, qemu-ppc@xxxxxxxxxx, huth@xxxxxxxxxxxxx, amarkovic@xxxxxxxxxxxx, imammedo@xxxxxxxxxx, aurelien@xxxxxxxxxxx, stefanb@xxxxxxxxxxxxx
- Delivery-date: Wed, 07 Aug 2019 10:27:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Openpgp: preference=signencrypt
On 07/08/19 10:33, tony.nguyen@xxxxxx wrote:
> +#ifdef NEED_CPU_H
> + return ctz32(size) | MO_TE;
> +#else
> return ctz32(size);
> +#endif
Please use two separate functions for this, for example size_to_memop
and target_size_to_memop, or even just add MO_TE to the callers that
need it (only cputlb.c?).
Paolo
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
