[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] passthrough/amd: Drop "IOMMU not found" message


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: "Woods, Brian" <Brian.Woods@xxxxxxx>
  • Date: Tue, 6 Aug 2019 18:37:45 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3cwRaZ/X74YllNTIO55g5IATdN3MsU2KdOjMnMknFY4=; b=TOglyQ+3dWAXRH+Gb/OUvcY15YHlbOGnwl7llwEgeljACKz5fUb27Q30yG9NIWEfv9FogiLuOX3KDGNvSUSjF8hQJCYBSKucy8g4YPAY3jaAoFUa5VSO1gv7ddrkUl8h40VHQmp1NUNSfqJ7N7NeAK1Aec0cP9UyjjpQm7TwRTzoKTduVypzKktqcdHi7c4BlEmeCN9dgW+q6F6vl4l9j/UF4wGE8dc3c/zBhai+cjPyDjDy3OOxRNcDsP8COsSxSnNOp76E1L5gHJzbVfuQpY1jUhhrcGgKpPk9nXq6hE+21T+vnbAZ7KTCxU44Y5i/+gHISUCfw6aJi7iOF6UvyQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eO05viA7y4t0jB1OJ7TxOL+XvIXZrkFZu3b3IiEgcYyYDR+Twn81HSZQ3+ikOPFriXeF21TNlZOvBkCEL2ABLLq2gWtTOWMFB5JLiCPc4SZdRC+Qd743G8JK2iNMwYC9zO4CpYKtR4/2Cr3lo7fA2UFfVokY3sBymzVW182RqDq4Nhft2SYA5Zaxxc2UmVeq3BzdA0VHSUzgmBcqvW39u48Zuxxzb4TzGNdgnYyh9DX1X1eq0X5dcULkEmDv8O6NaQ9DVuCUyX+zq2+mQy7BAoOaOStCnYZUsHJcbg4dSpQ5ODw94wF2eRCdDu+RtMKgrDvZU2bXBEsPyEsnEyTokQ==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Brian.Woods@xxxxxxx;
  • Cc: Jan Beulich <JBeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, "Woods, Brian" <Brian.Woods@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 06 Aug 2019 18:37:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVS60UpmtD3GyXR0aOHOgRDYWsaqbudLUA
  • Thread-topic: [PATCH] passthrough/amd: Drop "IOMMU not found" message

On Mon, Aug 05, 2019 at 05:44:30PM +0100, Andy Cooper wrote:
> Since c/s 9fa94e10585 "x86/ACPI: also parse AMD IOMMU tables early", this
> function is unconditionally called in all cases where a DMAR ACPI table
> doesn't exist.
> 
> As a consequnce, "AMD-Vi: IOMMU not found!" is printed in all cases where an
> IOMMU isn't present, even on non-AMD systems.  Drop the message - it isn't
> terribly interesting anyway, and is now misleading is a number of common
> cases.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Brian Woods <brian.woods@xxxxxxx>

> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> CC: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> CC: Brian Woods <brian.woods@xxxxxxx>
> ---
>  xen/drivers/passthrough/amd/pci_amd_iommu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c 
> b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> index b3e1933b53..3bcfcc8404 100644
> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -155,7 +155,6 @@ int __init acpi_ivrs_init(void)
>  
>      if ( (amd_iommu_detect_acpi() !=0) || (iommu_found() == 0) )
>      {
> -        printk("AMD-Vi: IOMMU not found!\n");
>          iommu_intremap = 0;
>          return -ENODEV;
>      }
> -- 
> 2.11.0
> 

-- 
Brian Woods

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.