Re: [Xen-devel] [PATCH] libacpi: report PCI slots as enabled only for hotpluggable devices

[Jan Beulich <JBeulich@xxxxxxxx>]

On 05.08.2019 16:50, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH] libacpi: report PCI slots as enabled only 
> for hotpluggable devices"):
>>>>> On 23.05.19 at 17:20, <wei.liu2@xxxxxxxxxx> wrote:
>>> On Thu, May 23, 2019 at 02:57:49AM -0600, Jan Beulich wrote:
>>>>>>> On 22.05.19 at 20:10, <igor.druzhinin@xxxxxxxxxx> wrote:
>>>>> DSDT for qemu-xen lacks _STA method of PCI slot object. If _STA method
>>>>> doesn't exist then the slot is assumed to be always present and active
>>>>> which in conjunction with _EJ0 method makes every device ejectable for
>>>>> an OS even if it's not the case.
>>>>>
>>>>> qemu-kvm is able to dynamically add _EJ0 method only to those slots
>>>>> that either have hotpluggable devices or free for PCI passthrough.
>>>>> As Xen lacks this capability we cannot use their way.
>>>>>
>>>>> qemu-xen-traditional DSDT has _STA method which only reports that
>>>>> the slot is present if there is a PCI devices hotplugged there.
>>>>> This is done through querying of its PCI hotplug controller.
>>>>> qemu-xen has similar capability that reports if device is "hotpluggable
>>>>> or absent" which we can use to achieve the same result.
>>>>>
>>>>> Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
>>>>
>>>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>>>>
>>>
>>> Jan, FAOD since you're the maintainer I'm expecting you to push this
>>> patch yourself.
>>
>> Sure, I have it on my list of things to push.
> 
> Is this a backport candidate ?  It sounds like it might be a bugfix
> but I don't understand the risks/implications.

I did already take the liberty of backporting this (back in June).

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel