Re: [Xen-devel] [PATCH] CODING_STYLE: clarify function argument indentation

[Juergen Gross <jgross@xxxxxxxx>]

On 01.08.19 11:55, Anthony PERARD wrote:
> On Wed, Jul 31, 2019 at 05:57:32PM +0000, Volodymyr Babchuk wrote:
> > Lars Kurth writes:
> > > Ultimately we have to make some trade-offs as to what is more important:
> > > a) automatic style checking - which means "common sense" can't be formalised 
> > > and there will be boundary cases like the above
> > > b) reclaiming code review bandwidth through automation or going for a labour 
> > > intensive manual approach
> > I like the linux kernel approach.  checkpatch.pl produces errors, which are
> > "no go", but it also produces warnings for such boundary cases, for
> > maintainer/reviewer to decide.
> Yes! QEMU also uses checkpatch.pl script and I found that very useful
> (both as reviewer and author of a patch). It tells you what are the
> coding style violation in newly added code and doesn't try to reformat
> the whole file.
>
> But that script would needs quite a lot of rewriting, I think, to be
> able to be used on the multiple coding style of xen.git.
We could start with only a few tests and enhance it later.

A good approach might be:

1. test commit message (e.g. is "Signed-off-by:" included, line
   length, ...)

2. add information which file is using which coding style, split
   patches to snipplets for each patched file, call style specific
   checker for each patched file (empty at the beginning)

3. re-use Linux kernel checkpatch.pl for checking kernel style files

4. introduce basic checks for Xen styles (e.g. indentation via spaces,
   line length checks, ...)

5. enhance Xen checks step by step


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel