[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 1/6] domain: stash xen_domctl_createdomain flags in struct domain
- To: Paul Durrant <paul.durrant@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Tue, 30 Jul 2019 09:25:42 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nuOmEbuFZEAmyUFfx8Ga+gl0RhxRuHwSJkSV3MFtve4=; b=Zbh8cDHt4bix22D1d0SuLXCFlcjY4/druOWUJ+Ng3uy8i/SeaJ/AvooMU6MzGCUfcVBQnrBdHnKWnPGNyLd/tbG4ohPYgVsQEFTJmRZNCKugmZA9smAXuuMYh9rrxPfjChMIYiqMoZlOouFfWyRa+692XHpM6asfu5MXzckDUuVOLLscHJ+WtozmiIwrbfvK4xEVkP+/Na1vLq02BXO7ZRmxHDJp7LxqpWhbNjKf908YBYFOosIyyBQy5uEwqAhmWsMtnvpWz0ETuJnmCxPBwhcKqf+JpDrE01PProGnj20HgjLCuzV7cbqyevDumJZhFGLXaTk/+EwsZogryoLxhw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WvD6C5rcC1QOlXQm6FmPY/+jZSgdOznk9xSZtc+bmNvhVZzm+igCaTcf08IXgkrhdz6K9Q+QbogVMYUrSljnSVjtSCqW2GrAR9/59g+atGRy2ccbn1+mSTxXpRL84O4bNlP3K3yF9LZ0LDSeRVNnKlkhT4BYV816U9iYeiV5pDj308I5fcPXsrwWZ359YQSR8IO4Sx2ZMDbP9hOW3xh9OZuQwcyTrf0C/UHBCfvVezd4h9L5bnYj47cPkddUXkrht4efEhL7BukA6t8bAC2Dn7nCRsuBI5l246JHSA/9edffX5hf1CJD2S0P/NtGLIqUGghRUcSRusultVgUvjvUDw==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, JulienGrall <julien.grall@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 30 Jul 2019 09:40:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVQu6akvnjr7AS1UCxO+8m8M4Duqbi6UsAgAACVAA=
- Thread-topic: [Xen-devel] [PATCH v2 1/6] domain: stash xen_domctl_createdomain flags in struct domain
On 30.07.2019 11:17, Jan Beulich wrote:
> On 25.07.2019 15:39, Paul Durrant wrote:
>> --- a/xen/include/xen/sched.h
>> +++ b/xen/include/xen/sched.h
>> @@ -306,6 +306,7 @@ enum guest_type {
>>
>> struct domain
>> {
>> + unsigned int options; /* copy of createdomain flags */
>> domid_t domain_id;
>>
>> unsigned int max_vcpus;
>
> I was about to commit this when I noticed the placement here:
> I think it would be pretty good to retain domain_id as the
> first field. I'll be happy to make that adjustment while
> committing, as long as you are fine with me doing so.
And I realize I should have said where I'd want to put it: I
think it wants to go next to guest_type, so that once that
field goes away structure layout (i.e. holes and overall size)
is the same again.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
