[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 06/10] xen/nodemask: Introduce a NODEMASK_PR() wrapper for printing
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Tue, 30 Jul 2019 08:58:34 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l6/Qf7WyR+/noLWcF2jFGedo9zbYggVclj9jRPJvjkY=; b=CJQ+GVvMzAS9ut1Y9ZiiGX2naSXvf2hYk+tVxlmZvy/2JOQvWXCuHEiUTc603s2q8wXcGEtKoFwuo2in0Fi4I64GpWyzDFCDQMk4V3DZbDzoKkfD4QtohnPYYHPih/UhuNeZZuN4k1J65A3B40KFt6OpVyuwAo9EivVFGwRM2u18BcTinlk1Ouohz6uA8RBrLnGtJvElbn2+rKFxywfeUbOfVvFUKJ3z91SdKv5Zhy0041WNE3fFneJtkRsQt45qCyxuWeX12x4ND47o3Ufx03SLFkqZhuaaCB4TaUI2SsGEJ7B2fC2Qbt7whd4RtVCbVYJnaEPkWRWnf+PG7Wfi5Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PhHBrJSsgaeS/RvtXmEyg4uERNX9TOyAf2AJFCkhIv8PP90PvBNqJ+O2JbkJmyqySMbCt0YVywBpYT665gSctCWgJUK8HcGlB+sH2zdCSiDgrkRd+4079ljJWOV6He2sPPXYIb5y9W2Xv4S5nJyenPZ6gqrOjdz+4Lx9sgIuVCTmWxb3J9RRtZ1J/xuroylIrxe+LnI9oZBII21HaammH8ioOJhOpdbUqFmW+vJlzGoFwJ4FOLslDu8m0nEWzoYlMgyXjBIcbH5CCJ1/fR8oU/9mMCQTkKM5fu3slMeTzHvIG7NiIqbyCxNvd1aZT8TZePTqirBQ21nsdejNvD6LrQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: StefanoStabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 30 Jul 2019 09:04:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVRgbpwCHNZFsIO0SvCXunCREMG6bi3doA
- Thread-topic: [PATCH v3 06/10] xen/nodemask: Introduce a NODEMASK_PR() wrapper for printing
On 29.07.2019 14:12, Andrew Cooper wrote:
> Rework nodes_addr() into nodemask_bits() and change the indirection to match
> its cpumask_bits() counterpart, and update the caller.
>
> Use NODEMASK_PR() to fix up one opencoded access into nodemask.bits in
> dump_domains().
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit I think that ...
> @@ -58,6 +58,15 @@
> #include <xen/numa.h>
>
> typedef struct { DECLARE_BITMAP(bits, MAX_NUMNODES); } nodemask_t;
> +
> +/*
> + * printf arguments for a nodemask. Shorthand for using '%*pb[l]' when
> + * printing a nodemask.
> + */
> +#define NODEMASK_PR(src) MAX_NUMNODES, nodemask_bits(src)
> +
> +#define nodemask_bits(src) ((src)->bits)
... it would be nice if nodemask_bits() was defined before its first
use, no matter that such ordering is irrelevant for macros.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
