[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 2/6] domain: remove 'guest_type' field (and enum guest_type)
- To: Paul Durrant <paul.durrant@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Mon, 29 Jul 2019 14:27:05 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OOpwW9z4opfiTO8f5UeO3lfmqrWbYXmX5gbm6IfLmj4=; b=CGM0OBcLKGLNycT709UKFWvzmqAgw42UuF5edDrDK0fHXs972bwByc+hLnjaFZ2UWU0Uc3+fc9u0UiMJQhadN89Qi7EKfpo/7L9ipxokZabrHPnKjQkzwHHwL5wBVHwssUHKpB44oSKXHymL3gzJtZr+XL9QwEFfWJt9w9I0ehXIUyVmKcHxGTNgWmGsu8lqeQW/Ir/JM16EDqROaC0JKZ6isjRLjzEjGUGt8kQeDMLmqzngRMiyurM+WT4nPv4tUsJQqaho273uuteIQNtA/OsSoXqwyvt9Eo/LLPjr00CViGkzQbUhv9t9mnAXzs27spGds/giYtnPCSwekWQFhQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XYkc+c+r7A7odw9vrHrGkuJ6n6HRcVG75PZtsXcgPbiRNarAxgIP90lzgzEMBL64N/pvk2L/GHWEhdUnKL2uHx1cvE06B69GL5po9AsMaFip/CIeAy1cnhYfpTzv19tZ5FCbAxW1XW84Umi9lN3B2miKUjw5y2/fE2vypx0eqhFIg6fQ8xPy5VGVijbup2VyvK4LUSdVwG9nUXmXSBRFUmTwLDIHQr/T+/ja9zNU8e2wYOX3LXkclab60u71a9hZhrNA7EOdCQFFOK4pNHpWSI+FlHeq+hsGd0Bx8gE9gCiCTjVtkwHx635OZUgnO71lp3eoyCyNjTBk1Lyoig9kzg==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, TimDeegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 29 Jul 2019 14:48:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVQu51p3+tO9+a50epDLWv6WiT+6bhrXwA
- Thread-topic: [PATCH v2 2/6] domain: remove 'guest_type' field (and enum guest_type)
On 25.07.2019 15:39, Paul Durrant wrote:
> @@ -916,8 +910,8 @@ void watchdog_domain_destroy(struct domain *d);
>
> static inline bool is_pv_domain(const struct domain *d)
> {
> - return IS_ENABLED(CONFIG_PV)
> - ? evaluate_nospec(d->guest_type == guest_type_pv) : false;
> + return IS_ENABLED(CONFIG_PV) &&
> + !evaluate_nospec(d->options & XEN_DOMCTL_CDF_hvm_guest);
I think the ! should move inside evaluate_nospec(). With this (which
can be easily done while committing, if no other need for a v3 arises)
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
