[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 3/4] xen/percpu: Drop unused asm/percpu.h includes
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Mon, 29 Jul 2019 12:53:41 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KArDCDzaoccWzERgANg3cd9oCQ/hl0KOmmIVDonsYYg=; b=iswXSUrwLjJcOe2c14/mVm6ZS+pJsa/sTc3nJmwOee/GM4pbqtZ6USowmUSiG207ybvJYegALKrMVj65T8mpxf0hZGRibySLf44LvlmhW8budsqV8/Ls1jy9xP50EaUnQMeF6FgzDmVCVEVoRRdxe0vsiA1U5rLG5zpSZ4L7dt8eCzIF37rOj4jEDh8Und+Pqhe+xJm7urLH9qdj+Ew1ldN/u0NXrAakiFECCzExTIkYfrBjstLdtI5gZFKTpFfBFlviO1Oqu+hoFVDurvXhKXsdHZUq1p7pl7WANPoHoPjnR9Pcsqzt7S42IbMUBwp9QWMTr2Lx+J3s3V4D1yC/zg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GUUjNa4N2BBINRYvOK1yQr0uvMBKQJ7QhX9JS0T2Jmb529TFQBfP3+U7DVibfUQjTAnR9CkPS/KfdchOWOogjRVqdpOvwIqX0Q8wxvrG+7GnvY28ApZeXJpDtPcY0X7PcLlhwt05qtbcR/aOe9gNeL6YzQGU6yEIZRTkOWKSInUDe0IXGgsw/X/rP2/Gkb6Rl1AF7lj3TnDDalj5MeljM4fTAnv75uDamTA5N6zt++mQv9908ldBsK1CF3naXy21FykJTgUks+M0RDbJnJdBIiFnjuBFKsMKqoP8hJ62XDdAXDbknfTkUZ5VA5ugqndiRrvdIjlBg0zQCvq7t3T7RA==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 29 Jul 2019 13:14:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVQ/aTcbyZijQELUWr8Cax2G1o4abhkVUA
- Thread-topic: [Xen-devel] [PATCH 3/4] xen/percpu: Drop unused asm/percpu.h includes
On 26.07.2019 23:08, Andrew Cooper wrote:
> These files either don't use any PER_CPU() infrastructure at all, or use
> DEFINE_PER_CPU_*(). This is declared in xen/percpu.h, not asm/percpu.h, which
> means that xen/percpu.h is included via a different path.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
with a remark:
> --- a/xen/common/core_parking.c
> +++ b/xen/common/core_parking.c
> @@ -19,7 +19,7 @@
> #include <xen/cpu.h>
> #include <xen/init.h>
> #include <xen/cpumask.h>
> -#include <asm/percpu.h>
> +
> #include <asm/smp.h>
I don't believe in such blank lines to be overly useful,
especially when ...
> --- a/xen/include/xen/kexec.h
> +++ b/xen/include/xen/kexec.h
> @@ -4,7 +4,6 @@
> #ifdef CONFIG_KEXEC
>
> #include <public/kexec.h>
> -#include <asm/percpu.h>
> #include <xen/elfcore.h>
> #include <xen/kimage.h>
... this model isn't being followed consistently.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
