Re: [Xen-devel] [PATCH 5/6] domain: remove the 'is_xenstore' flag

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> Sent: 25 July 2019 10:48
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Stefano Stabellini 
> <sstabellini@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>;
> Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>; George Dunlap 
> <George.Dunlap@xxxxxxxxxx>; Andrew
> Cooper <Andrew.Cooper3@xxxxxxxxxx>; Ian Jackson <Ian.Jackson@xxxxxxxxxx>; Tim 
> (Xen.org) <tim@xxxxxxx>;
> Julien Grall <julien.grall@xxxxxxx>; Jan Beulich <jbeulich@xxxxxxxx>; Daniel 
> De Graaf
> <dgdegra@xxxxxxxxxxxxx>
> Subject: Re: [Xen-devel] [PATCH 5/6] domain: remove the 'is_xenstore' flag
> 
> On Tue, Jul 23, 2019 at 05:06:08PM +0100, Paul Durrant wrote:
> > This patch introduces a convenience macro, is_xenstore_domain(), which
> > tests the domain 'createflags' directly and then uses that in place of
> > the 'is_xenstore' flag.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> 
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 

Thanks.

> Just one request below (which is not related to your code actually).
> 
> > ---
> > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Jan Beulich <jbeulich@xxxxxxxx>
> > Cc: Julien Grall <julien.grall@xxxxxxx>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > Cc: Tim Deegan <tim@xxxxxxx>
> > Cc: Wei Liu <wl@xxxxxxx>
> > Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> > ---
> >  xen/common/domain.c     | 5 +----
> >  xen/common/domctl.c     | 2 +-
> >  xen/include/xen/sched.h | 7 +++++--
> >  xen/include/xsm/dummy.h | 2 +-
> >  4 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/xen/common/domain.c b/xen/common/domain.c
> > index 6f405d2541..5703da357f 100644
> > --- a/xen/common/domain.c
> > +++ b/xen/common/domain.c
> > @@ -429,11 +429,8 @@ struct domain *domain_create(domid_t domid,
> >          watchdog_domain_init(d);
> >          init_status |= INIT_watchdog;
> >
> > -        if ( d->createflags & XEN_DOMCTL_CDF_xs_domain )
> > -        {
> > -            d->is_xenstore = 1;
> > +        if ( is_xenstore_domain(d) )
> >              d->disable_migrate = 1;
> 
> While here can you also fix this line to use true instead of 1?
> 

Sure.

  Paul

> Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel