|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 1/2 RESEND] CODING_STYLE: explicitly call out label indentation
On Fri, Jul 19, 2019 at 7:22 AM Jan Beulich <JBeulich@xxxxxxxx> wrote: > > On 19.07.2019 15:18, Tamas K Lengyel wrote: > > On Fri, Jul 19, 2019 at 3:19 AM Jan Beulich <JBeulich@xxxxxxxx> wrote: > >> > >> Since the behavior of "diff -p" to use an unindented label as context > >> identifier often makes it harder to review patches, make explicit the > >> requirement for labels to be indented. > >> > >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> > > > > This style requirement wouldn't really work with astyle as-is. > > Personally I view proper "diff -p" context in patches as quite > a bit more important than automatic style checking. But perhaps > that's just because I do quite a lot of patch review ... Which is a valid point. I don't really care which style option it really is, if it helps you, I'm fine with it. But as a maintainer who does this on a volunteer basis when I have a 5-minute window, I'm not going to spend my time looking for style issues. So in the ongoing vm_event series that's under review where you explicitly called out that the vm_event maintainers have to review and point out all style issues, that's a no-go from my side. So either we have automatic style checks or I'm just going to Ack patches with style issues. Tamas _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |