[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting
- To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Fri, 19 Jul 2019 09:00:10 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c17WKOHBWpNd5V4THty9keKLbJf6cdmzzAyNJhNWg9g=; b=U6DLB9Ogp+0OWShsmKv0r9aj1L9OXp5LoFvPoJLrRYl0Kh3Wd1FmsqBnUXJPzKBUJSb4XuweWzS7RLvQuxQDKvyJqaLc+21LW368fbq1WYm2pKezrLf1U+zYP2kGREv225mJzC4SFKJZNMMvNiQRGr30DCqrO+45ORHoSLvMa7YMO5shp+uvdYXoNZ2bZpWUg8No2C4AqEyjpXTSx4gAdf7oBss8V0sQCc+bnusRHMQV2b9DiCWLeAhLgezerbrvqTGz+voO5TvqyAHCYA40ItabsLEUVEcPSy1JfchPjtNmHv2jY9Rm2F6BFJG13cAwqTUoBLzHwbLpNUyd51OMyg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lZXUcHzDY8Gw+WwHJ+kATkTRqGnO3apuzsiULKeaj5W5keG3BnvuUdBV80YzmhsA/FudE6KamXdxxzAnG0kI44YD77gw8mm/Gs2xTx1j9FnlFcelf5Qkp6DJhoj6nXle18Spz8JiMRriPdov7ZFuewreiQ0Jm5DfKYtVdkZqb6PXd/mBLiInfm0Fo1+HA7EBf0hJ19VcV6xuQQpzkJX+jkibodldzlmTlccBDM43o2HpjqQScwpvW+CGfKNmlxVyZdYlMQCIoXoIC18CbmGqi6V73fjH+gpNQcubFpKyrSEy+Tl2CBYkKrsMn9xFbwZZOLOJ5dihcnlZ+ifSOSOlxw==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, Lars Kurth <lars.kurth@xxxxxxxxxx>, Iurii Artemenko <Iurii_Artemenko@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 19 Jul 2019 09:01:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPXcqh/rpHqCfrE2r6qBBgy1Fu6bQeNoBgAADe8CAAAegOoAAG/bGgAEF3gA=
- Thread-topic: [RFC] xen: Add .astylerc for automated style-formatting
On 18.07.2019 19:22, Tamas K Lengyel wrote:
>> - Line 139: The { are commonly on the same line as struct or definition.
>
> According to CODING_STYLE that's not how it should be.
Having the brace on the same line there is rather helpful to easily
tell the definition point of a struct/union/enum from any of its uses.
Hence no matter whether ./CODING_STYLE doesn't explicitly cover this
fact, I think we want to stick to the (Linux inherited I think) form.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
