|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] printf formatter for pci_sbdf_t
On 18.07.2019 17:14, Roger Pau Monné wrote:
> On Thu, Jul 18, 2019 at 11:51:57AM +0000, Jan Beulich wrote:
>> On 17.07.2019 19:06, Andrew Cooper wrote:
>>> On 17/07/2019 15:08, Roger Pau Monné wrote:
>>>> As part of some PCI related cleanup I'm doing, which includes
>>>> expanding the usage of pci_sbdf_t, I'm also planning to add a custom
>>>> printf formatter for pci_sbdf_t [0], so that a SBDF can be printed
>>>> without having to specify four formatters (and pass four parameters)
>>>> each time (%04x:%02x:%02x.%u).
>>>>
>>>> There's been some debate on the previous version about whether the
>>>> formatter should be %pp or %op, and I would like to settle on one of
>>>> them before sending a new version:
>>>
>>> I am firmly opposed to overloading %o.
>>
>> And I am firmly of the opinion that using %o for SBDF is the more
>> natural thing to do.
>>
>>> Nothing about PCI coordinates has anything to do with octal
>>> representation; its mostly hex.
>>
>> The domain and vCPU IDs aren#t pointer-ish either, for example.
>
> But we do pass the vcpu and the domain struct pointer to those
> modifiers? ie: we don't pass a vcpu or a domain ID directly in either
> case.
Right. My point was: The actual format specifier used ('p' or 'o')
doesn't necessarily have anything to do with the resulting output.
> AFAICT both you an Andrew agree that a custom printf formatter for PCI
> SBDF is a desirable thing to have, the only disagreement is on the
> actual implementation detail (whether %pp or %op should be used). In
> which case I think I would like to call for THE REST to also voice in
> their opinion on the matter in order to try to resolve the situation
> so that I can make progress on the series, sorry if this is awkward.
That's perfectly fine with me. If a majority agrees with Andrew,
so be it.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |