[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] xen/trace: Adjust types in trace_var() declarations
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Thu, 18 Jul 2019 15:23:38 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=07A0HDpuygHnYvbwb2RXoC4G7XDKDsajtyfq2kvfHLs=; b=DjQgrH21ZkVoP6T69ARwu6w2n58JCWmwY2TWyjHxMXHyfPNZZ0+6SR9m+xCFtMddQ+1wE1n8PF2Pp7eJ4/r1Hb5JhxUM4/mpP2ImEIN32io5sLV71htbGbYXxquIcmdga6lkRJLfEMHMogxe6M402IaZS1UaWF5w0q/ASHkRFrvebzR+ZQCvEllhkdc/n38N+ZiNi4wJlhqc5m//SU6TnLhzJY7ZEPBtJ8YjeCBxdzBbUcmdxhN2DmNrDZGgRSa2jKrxxRj0PKPh8Ag/1EMwBTADbypRqt5EpXD41Utd7g0WRkz9Ixh7T5vS+1qADK7PMaWPtSJQ2UFYp/b7+KWZZg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m2WZD4m50BP1DPD1HLIiUnQ13P6cO6a4GDdeIfMy7t2PKmReh0NetnYGT5MCtcLqlxFrjBlT0m0/2dllsEVGEskkeoBEN4WytTd6pJgyGqrnLhRkgWMkHRubJ3XEVRogVjsnDOrs1Bkxat5DeTiLUtOzvnw8LNp8+7pG7LFejhTNEGIfAwVB34Tv0IQ3o0l2907oV7/jM4wY1JS+hnxjwYxq2FsAna65/LvAGbHxsRLHwaCBAkgrkl8JlATHlpMwAxyHzD7VYSKmqHEDHST4Ax7ZykDUrVY5jU41Y2QX1NJs0fsz5eBGLwLRgQPQzeo0ktJnAWBjIYp9vC6LS2b0MA==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 18 Jul 2019 15:24:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPXEn9tz4a96/o0e+1XNlyOHUq6bQfqQA
- Thread-topic: [PATCH] xen/trace: Adjust types in trace_var() declarations
On 18.07.2019 16:00, Andrew Cooper wrote:
> Use bool rather than int/bool_t for 'cycles' to match the !CONFIG_TRACEBUFFER
> version, and use unsigned int rather than int for 'extra' to match the
> function it is forwarded to.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit I'd have expected the file to by part of the XENTRACE
section of ./MAINTAINERS.
> --- a/xen/include/xen/trace.h
> +++ b/xen/include/xen/trace.h
> @@ -41,9 +41,9 @@ int tb_control(struct xen_sysctl_tbuf_op *tbc);
>
> int trace_will_trace_event(u32 event);
>
> -void __trace_var(u32 event, bool_t cycles, unsigned int extra, const void *);
> +void __trace_var(u32 event, bool cycles, unsigned int extra, const void *);
>
> -static inline void trace_var(u32 event, int cycles, int extra,
> +static inline void trace_var(u32 event, bool cycles, unsigned int extra,
> const void *extra_data)
Would be nice if the u32-s here could go away at the same time.
Ideally they'd become unsigned int, but I guess you're once
again rather seeing them be uint32_t.
Also wouldn't you better adjust __trace_var()'s definition as well
at this occasion?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
