Re: [Xen-devel] [PATCH v7 4/5] x86/paravirt: Remove const mark from x86_hyper_xen_hvm variable

[Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>]

On 2019/7/16 18:57, Juergen Gross wrote:
> On 11.07.19 14:02, Zhenzhong Duan wrote:
> > .. as "nopv" support needs it to be changeable at boot up stage.
> >
> > Checkpatch report warning, so move variable declarations from
> > hypervisor.c to hypervisor.h
> >
> > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>
> > Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> > Cc: Juergen Gross <jgross@xxxxxxxx>
> > Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Borislav Petkov <bp@xxxxxxxxx>
> > ---
> >   arch/x86/include/asm/hypervisor.h | 8 ++++++++
> >   arch/x86/kernel/cpu/hypervisor.c  | 8 --------
> >   2 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/x86/include/asm/hypervisor.h 
> > b/arch/x86/include/asm/hypervisor.h
> > index f7b4c53..e41cbf2 100644
> > --- a/arch/x86/include/asm/hypervisor.h
> > +++ b/arch/x86/include/asm/hypervisor.h
> > @@ -58,6 +58,14 @@ struct hypervisor_x86 {
> >       bool ignore_nopv;
> >   };
> >   +extern const struct hypervisor_x86 x86_hyper_vmware;
> > +extern const struct hypervisor_x86 x86_hyper_ms_hyperv;
> > +extern const struct hypervisor_x86 x86_hyper_xen_pv;
> > +extern const struct hypervisor_x86 x86_hyper_kvm;
> > +extern const struct hypervisor_x86 x86_hyper_jailhouse;
> > +extern const struct hypervisor_x86 x86_hyper_acrn;
> > +extern struct hypervisor_x86 x86_hyper_xen_hvm;
> This should either stay const and be changed in patch 5, or you
> should adapt its definition in arch/x86/xen/enlighten_hvm.c in
> this patch.
Ok, thanks for your suggestion.

I'll choose 2nd opinion as I don't need to change descripton with that.

Zhenzhong


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel