Re: [Xen-devel] [PATCH] xen/Kconfig: Fix -Wformat-security when compiling with Clang

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.06.19 at 19:36, <andrew.cooper3@xxxxxxxxxx> wrote:
> Clang observes:
> 
> tools/kconfig/conf.c:77:10:
> warning: format string is not a string literal (potentially insecure)
>       [-Wformat-security]
>                 printf(_("aborted!\n\n"));
>                        ^~~~~~~~~~~~~~~~~
> 
> And it is absolutely correct.  gettext() can easily return a string with a %
> in.

I'm pretty curious: Where would a % come from when there's none
in the original English string? I wouldn't call it "proper translation" if
a translated string had non-textual things in it that the original didn't
have. Or are there languages using % in ordinary words?

Note that this is in no way an objection to the change, the more
that it's a reduction of source size.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel