Re: [Xen-devel] [PATCH 11/17] xen/arm64: head: Document enable_mmu()

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 26/06/2019 02:03, Stefano Stabellini wrote:
> On Mon, 10 Jun 2019, Julien Grall wrote:
> > Document the behavior and the main registers usage within enable_mmu().
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> > ---
> >   xen/arch/arm/arm64/head.S | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> > index 7b92c1c8eb..d673f7c0d8 100644
> > --- a/xen/arch/arm/arm64/head.S
> > +++ b/xen/arch/arm/arm64/head.S
> > @@ -583,6 +583,13 @@ virtphys_clash:
> >           ret
> >   ENDPROC(create_page_tables)
> >   
> > +/*
> > + * Turn on the Data Cache and the MMU. The function will return on the ID
> > + * mapping. In other word, the caller is responsible to switch to the runtime
> > + * mapping.
> > + *
> > + * Clobbers x0 - x1
> > + */
> as it calls PRINT, shouldn't it be x0 - x3?
You are right. I will update the comment.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel