Re: [Xen-devel] [PATCH] xen/public: arch-arm: Use xen_mk_ullong instead of suffixing value with ULL

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

Gentle ping.

Cheers,

On 03/06/2019 17:08, Julien Grall wrote:
> There are a few places in include/public/arch-arm.h that are still
> suffixing immediate with ULL instead of using xen_mk_ullong.
>
> The latter allows a consumer to easily tweak the header if ULL is not
> supported.
>
> So switch the remaining users of ULL to xen_mk_ullong.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> ---
>   xen/include/public/arch-arm.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index eb424e8286..f550137089 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -407,12 +407,12 @@ typedef uint64_t xen_callback_t;
>   #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
>   
>   /* ACPI tables physical address */
> -#define GUEST_ACPI_BASE 0x20000000ULL
> -#define GUEST_ACPI_SIZE 0x02000000ULL
> +#define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
> +#define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
>   
>   /* PL011 mappings */
> -#define GUEST_PL011_BASE    0x22000000ULL
> -#define GUEST_PL011_SIZE    0x00001000ULL
> +#define GUEST_PL011_BASE    xen_mk_ullong(0x22000000)
> +#define GUEST_PL011_SIZE    xen_mk_ullong(0x00001000)
>   
>   /*
>    * 16MB == 4096 pages reserved for guest to use as a region to map its
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel