Re: [Xen-devel] [PATCH v2 3/3] x86/linker: add a reloc section to ELF binary

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.06.19 at 18:38, <roger.pau@xxxxxxxxxx> wrote:
> if the hypervisor has been built with EFI support (ie: multiboot2).
> This allows to position the .reloc section correctly in the output
> binary.

The title still says "add ... to ELF binary", when really such a section
is already there (and in fact that's the problem you're trying to work
around). As mentioned before, if anything you add mention of the
section to the linker script, but not to the ELF binary (afaict).

> Note that for the ELF output format the .reloc section is moved before
> .bss for two reasons: in order for the resulting binary to not contain
> any section with data after .bss, so that the file size can be smaller
> than the loaded memory size,

Sounds like another linker quirk then. I didn't think there was a
requirement for image and file offsets to go in lock step. There is
some correlation iirc, but the sentence may want weakening a little.

> and because the data it contains is
> read-only, so it belongs with the other sections containing read-only
> data.

I can accept this one (as a secondary argument).

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel