[Xen-devel] [xen-unstable-smoke test] 138342: regressions - FAIL

[osstest service owner <osstest-admin@xxxxxxxxxxxxxx>]

flight 138342 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/138342/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm       7 xen-boot                 fail REGR. vs. 138228

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     13 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          13 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          14 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  11911563610786615c2b3a01cdcaaf09a6f9e38d
baseline version:
 xen                  f3d8eef9091747e70c505094f63514b43329a922

Last test of basis   138228  2019-06-21 20:00:39 Z    1 days
Testing same since   138242  2019-06-21 23:01:48 Z    1 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@xxxxxxxx>
  julien.grall@xxxxxxx
  Stefano Stabellini <sstabellini@xxxxxxxxxx>
  Stefano Stabellini <stefanos@xxxxxxxxxx>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 11911563610786615c2b3a01cdcaaf09a6f9e38d
Author: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Date:   Fri Jun 21 13:20:25 2019 -0700

    xen/arm: fix mask calculation in pdx_init_mask
    
    The mask calculation in pdx_init_mask is wrong when the first bank
    starts at address 0x0. The reason is that pdx_init_mask will do '0 - 1'
    causing an underflow. As a result, the mask becomes 0xffffffffffffffff
    which is the biggest possible mask and ends up causing a significant
    memory waste in the frametable size computation.
    
    For instance, on platforms that have a low memory bank starting at 0x0
    and a high memory bank, the frametable will end up covering all the
    holes in between.
    
    The purpose of the mask is to be passed as a parameter to
    pfn_pdx_hole_setup, which based on the mask parameter calculates
    pfn_pdx_hole_shift, pfn_pdx_bottom_mask, etc. which are actually the
    important masks for frametable initialization later on.
    
    pfn_pdx_hole_setup never compresses addresses below MAX_ORDER bits (1GB
    on ARM). Thus, it is safe to initialize mask passing 1ULL << (MAX_ORDER
    + PAGE_SHIFT) as start address to pdx_init_mask.
    
    Signed-off-by: Stefano Stabellini <stefanos@xxxxxxxxxx>
    Reviewed-by: Julien Grall <julien.grall@xxxxxxx>
    Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

commit eb63e1225aba04c959eeb68eda99e422939c37de
Author: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Date:   Fri Jun 21 13:19:31 2019 -0700

    xen: Replace u64 with uint64_t in pdx_init_mask() and callers
    
    Xen is phasing out the use of u64 in favor of uint64_t. Therefore, the
    instance of u64 in the pdx_init_mask() (and the callers) are now
    replaced with uint64_t. Take the opportunity to also modify
    srat_region_mask as this is used to store the result of pdx_init_mask().
    
    Signed-off-by: Stefano Stabellini <stefanos@xxxxxxxxxx>
    Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: julien.grall@xxxxxxx
(qemu changes not included)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel