[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [OSSTEST PATCH v2 7/8] mg-repro-setup: actually accept --rebuild -rVAR=VALUE


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
  • Date: Fri, 21 Jun 2019 15:22:57 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@xxxxxxxxxxxxx; spf=Pass smtp.mailfrom=Ian.Jackson@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
  • Delivery-date: Fri, 21 Jun 2019 14:25:37 +0000
  • Ironport-sdr: KtkkrOuWUyDs/qU86cFHmQy/jbeO3R9bj13ZPFGMpuZcYlPeeFrNMdw6itf/5YigqE7WF91xvs F0vcCp+d2m9DZNZhp8XJhN52XzCvvTDPa8tjWvgJ0bGG+fa7GsDSUwOtGvWDzjCo1l9CtS6aly 2qVDsXfsoNHa2e4OEclwsQXDZybcpBMdhfOgRsZQt2wKTW1YoenJogiRpFyJVRrfs/scDep2cz x2Cu3l3tJfVZ6Dftp5KLLkEJpO4YrLteWZteeJ6a/PxaTPWDkHX3bQdAw4USsI8b6ii09TpyMM g44=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

The glob syntax here was wrong, and the code cs-adjust-flight did not
handle it properly either.  So --rebuild -r has not worked since it
first appeared in:
   a1e0e5846f7bb7d82a5db1d7cd643b9f5ca1b9a9
   mg-repro-flight: Provide --rebuild to make variant build jobs

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
v2: New patch
---
 cs-adjust-flight | 2 +-
 mg-repro-setup   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cs-adjust-flight b/cs-adjust-flight
index 5be5af38..ae342506 100755
--- a/cs-adjust-flight
+++ b/cs-adjust-flight
@@ -485,7 +485,7 @@ sub change__repro_buildjobs {
     my @refspecs;
     my @varspecs;
     my %treespecs;
-    while (@changes && $changes[0] =~ m/^[.=+]/) {
+    while (@changes && $changes[0] =~ m/^[.=+]|^-r/) {
        local $_ = shift @changes;
        if (m/^[.=]/) {
            push @refspecs, $_;
diff --git a/mg-repro-setup b/mg-repro-setup
index b55f021e..3ceb7032 100755
--- a/mg-repro-setup
+++ b/mg-repro-setup
@@ -187,7 +187,7 @@ while [ $# -ne 0 ]; do
                rebuild_specs=()
                while true; do
                        case "$1" in
-                       [.=+]*|-r) rebuild_specs+=("$1");       shift ;;
+                       [.=+]*|-r*) rebuild_specs+=("$1");      shift ;;
                        -B?*)   rebuilds_blessing=${1#-B};      shift ;;
                        -*)     badusage ': bad --rebuild option'     ;;
                         *)      break                                 ;;
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.