Xen project Mailing List

Re: [Xen-devel] [PATCH v3 0/2] Fix build of Xen support + cleanup

Date: Fri, 21 Jun 2019 06:33:28 -0700 (PDT)

Arc-authentication-results: i=1; mx.zoho.com; dkim=pass header.i=patchew.org; spf=pass smtp.mailfrom=no-reply@xxxxxxxxxxx; dmarc=pass header.from=<no-reply@xxxxxxxxxxx> header.from=<no-reply@xxxxxxxxxxx>

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561124011; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:Reply-To:Subject:To:ARC-Authentication-Results; bh=xCWy7V35GX1R7WVqcwQa7EBphroIGtcJ0NxxLTqi6aw=; b=Hf3oHaSgTJ5JTBZersK0Q0ortf81ZaixInPep/wrNQyDjjOzXU3SrMECn0aB9lJ5hWyva3GV5g+iUHky/KRuBqES9VqgsZilU3SsBLkQB+ZBugBWk31LGkz/Cu21n7w8GnaVnFXVTZq8VtYihfP3gieOWRuWUgfSAxxpY/PPU7o=

Arc-seal: i=1; a=rsa-sha256; t=1561124011; cv=none; d=zoho.com; s=zohoarc; b=Q0eRooiEQj7PfLVBQjH9IxeGKpgR3Zd21cNj/f1uKFvg/zLt7nuSYGOGMJg91d6s+DzEwGT5uNS1GEIC/jGrb/S7lBTAtWGJBvO4BGWwc4KMOy4V2ydNBdlTSTczukQrSfH/GbulL2Z9W3w2ukjKHc0tf65EeqlDbnyDFxJHGZc=

Cc: sstabellini@xxxxxxxxxx, berrange@xxxxxxxxxx, qemu-devel@xxxxxxxxxx, paul.durrant@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx

Delivery-date: Fri, 21 Jun 2019 13:34:38 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Resent-date: Fri, 21 Jun 2019 13:34:38 +0000

Resent-from:

Resent-message-id: <E1heJgc-00034S-AG@xxxxxxxxxxxxxxxxxxxx>

Patchew URL: https://patchew.org/QEMU/20190621105441.3025-1-anthony.perard@xxxxxxxxxx/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Xen-devel] [PATCH v3 0/2] Fix build of Xen support + cleanup Message-id: 20190621105441.3025-1-anthony.perard@xxxxxxxxxx === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' d40b5c4 xen: Import other xen/io/*.h 15aaf2a Revert xen/io/ring.h of "Clean up a few header guard symbols" === OUTPUT BEGIN === 1/2 Checking commit 15aaf2a35157 (Revert xen/io/ring.h of "Clean up a few header guard symbols") WARNING: architecture specific defines should be avoided #41: FILE: include/hw/xen/io/ring.h:27: +#ifndef __XEN_PUBLIC_IO_RING_H__ total: 0 errors, 1 warnings, 18 lines checked Patch 1/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/2 Checking commit d40b5c494561 (xen: Import other xen/io/*.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #134: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #139: FILE: include/hw/xen/interface/grant_table.h:1: +/****************************************************************************** WARNING: architecture specific defines should be avoided #166: FILE: include/hw/xen/interface/grant_table.h:28: +#ifndef __XEN_PUBLIC_GRANT_TABLE_H__ WARNING: Block comments use a leading /* on a separate line #181: FILE: include/hw/xen/interface/io/blkif.h:1: +/****************************************************************************** WARNING: architecture specific defines should be avoided #208: FILE: include/hw/xen/interface/io/blkif.h:28: +#ifndef __XEN_PUBLIC_IO_BLKIF_H__ ERROR: spaces required around that '<<' (ctx:VxV) #844: FILE: include/hw/xen/interface/io/blkif.h:664: +#define BLKIF_DISCARD_SECURE (1<<0) /* ignored if discard-secure=0 */ ^ WARNING: architecture specific defines should be avoided #860: FILE: include/hw/xen/interface/io/blkif.h:680: +#ifdef __i386__ WARNING: Block comments use a leading /* on a separate line #899: FILE: include/hw/xen/interface/io/console.h:1: +/****************************************************************************** WARNING: architecture specific defines should be avoided #925: FILE: include/hw/xen/interface/io/console.h:27: +#ifndef __XEN_PUBLIC_IO_CONSOLE_H__ ERROR: spaces required around that '-' (ctx:VxV) #930: FILE: include/hw/xen/interface/io/console.h:32: +#define MASK_XENCONS_IDX(idx, ring) ((idx) & (sizeof(ring)-1)) ^ WARNING: architecture specific defines should be avoided #976: FILE: include/hw/xen/interface/io/fbif.h:26: +#ifndef __XEN_PUBLIC_IO_FBIF_H__ ERROR: open brace '{' following struct go on the same line #995: FILE: include/hw/xen/interface/io/fbif.h:45: +struct xenfb_update +{ ERROR: open brace '{' following struct go on the same line #1010: FILE: include/hw/xen/interface/io/fbif.h:60: +struct xenfb_resize +{ ERROR: open brace '{' following union go on the same line #1022: FILE: include/hw/xen/interface/io/fbif.h:72: +union xenfb_out_event +{ ERROR: open brace '{' following struct go on the same line #1048: FILE: include/hw/xen/interface/io/fbif.h:98: +struct xenfb_refresh_period +{ WARNING: Block comments use a leading /* on a separate line #1050: FILE: include/hw/xen/interface/io/fbif.h:100: + uint32_t period; /* period of refresh, in ms, WARNING: Block comments use a trailing */ on a separate line #1051: FILE: include/hw/xen/interface/io/fbif.h:101: + * XENFB_NO_REFRESH if no refresh is needed */ ERROR: open brace '{' following union go on the same line #1057: FILE: include/hw/xen/interface/io/fbif.h:107: +union xenfb_in_event +{ ERROR: open brace '{' following struct go on the same line #1082: FILE: include/hw/xen/interface/io/fbif.h:132: +struct xenfb_page +{ WARNING: architecture specific defines should be avoided #1138: FILE: include/hw/xen/interface/io/kbdif.h:26: +#ifndef __XEN_PUBLIC_IO_KBDIF_H__ ERROR: open brace '{' following struct go on the same line #1383: FILE: include/hw/xen/interface/io/kbdif.h:271: +struct xenkbd_motion +{ ERROR: open brace '{' following struct go on the same line #1410: FILE: include/hw/xen/interface/io/kbdif.h:298: +struct xenkbd_key +{ ERROR: open brace '{' following struct go on the same line #1441: FILE: include/hw/xen/interface/io/kbdif.h:329: +struct xenkbd_position +{ ERROR: open brace '{' following union go on the same line #1615: FILE: include/hw/xen/interface/io/kbdif.h:503: +union xenkbd_in_event +{ ERROR: open brace '{' following union go on the same line #1645: FILE: include/hw/xen/interface/io/kbdif.h:533: +union xenkbd_out_event +{ ERROR: open brace '{' following struct go on the same line #1673: FILE: include/hw/xen/interface/io/kbdif.h:561: +struct xenkbd_page +{ WARNING: Block comments use a leading /* on a separate line #1685: FILE: include/hw/xen/interface/io/netif.h:1: +/****************************************************************************** WARNING: architecture specific defines should be avoided #1711: FILE: include/hw/xen/interface/io/netif.h:27: +#ifndef __XEN_PUBLIC_IO_NETIF_H__ ERROR: spaces required around that '<<' (ctx:VxV) #2057: FILE: include/hw/xen/interface/io/netif.h:373: +#define XEN_NETIF_CTRLF_GREF_readonly (1U<<_XEN_NETIF_CTRLF_GREF_readonly) ^ ERROR: spaces required around that '<<' (ctx:VxV) #2572: FILE: include/hw/xen/interface/io/netif.h:888: +#define NETTXF_csum_blank (1U<<_NETTXF_csum_blank) ^ ERROR: spaces required around that '<<' (ctx:VxV) #2576: FILE: include/hw/xen/interface/io/netif.h:892: +#define NETTXF_data_validated (1U<<_NETTXF_data_validated) ^ ERROR: spaces required around that '<<' (ctx:VxV) #2580: FILE: include/hw/xen/interface/io/netif.h:896: +#define NETTXF_more_data (1U<<_NETTXF_more_data) ^ ERROR: spaces required around that '<<' (ctx:VxV) #2584: FILE: include/hw/xen/interface/io/netif.h:900: +#define NETTXF_extra_info (1U<<_NETTXF_extra_info) ^ ERROR: spaces required around that '<<' (ctx:VxV) #2606: FILE: include/hw/xen/interface/io/netif.h:922: +#define XEN_NETIF_EXTRA_FLAG_MORE (1U<<_XEN_NETIF_EXTRA_FLAG_MORE) ^ ERROR: spaces required around that '<<' (ctx:VxV) #2655: FILE: include/hw/xen/interface/io/netif.h:971: +#define NETRXF_data_validated (1U<<_NETRXF_data_validated) ^ ERROR: spaces required around that '<<' (ctx:VxV) #2659: FILE: include/hw/xen/interface/io/netif.h:975: +#define NETRXF_csum_blank (1U<<_NETRXF_csum_blank) ^ ERROR: spaces required around that '<<' (ctx:VxV) #2663: FILE: include/hw/xen/interface/io/netif.h:979: +#define NETRXF_more_data (1U<<_NETRXF_more_data) ^ ERROR: spaces required around that '<<' (ctx:VxV) #2667: FILE: include/hw/xen/interface/io/netif.h:983: +#define NETRXF_extra_info (1U<<_NETRXF_extra_info) ^ ERROR: spaces required around that '<<' (ctx:VxV) #2671: FILE: include/hw/xen/interface/io/netif.h:987: +#define NETRXF_gso_prefix (1U<<_NETRXF_gso_prefix) ^ WARNING: Block comments use a leading /* on a separate line #2701: FILE: include/hw/xen/interface/io/protocols.h:1: +/****************************************************************************** WARNING: architecture specific defines should be avoided #2725: FILE: include/hw/xen/interface/io/protocols.h:25: +#ifndef __XEN_PROTOCOLS_H__ WARNING: architecture specific defines should be avoided #2732: FILE: include/hw/xen/interface/io/protocols.h:32: +#if defined(__i386__) WARNING: architecture specific defines should be avoided #2780: FILE: include/hw/xen/interface/io/usbif.h:28: +#ifndef __XEN_PUBLIC_IO_USBIF_H__ ERROR: code indent should never use tabs #2857: FILE: include/hw/xen/interface/io/usbif.h:105: +^IUSB_VER_UNKNOWN = 0,$ ERROR: code indent should never use tabs #2858: FILE: include/hw/xen/interface/io/usbif.h:106: +^IUSB_VER_USB11,$ ERROR: code indent should never use tabs #2859: FILE: include/hw/xen/interface/io/usbif.h:107: +^IUSB_VER_USB20,$ ERROR: code indent should never use tabs #2860: FILE: include/hw/xen/interface/io/usbif.h:108: +^IUSB_VER_USB30,^I/* not supported yet */$ ERROR: code indent should never use tabs #2866: FILE: include/hw/xen/interface/io/usbif.h:114: + * - port number:^Ibits 0-4$ ERROR: code indent should never use tabs #2867: FILE: include/hw/xen/interface/io/usbif.h:115: + *^I^I^I^I(USB_MAXCHILDREN is 31)$ ERROR: code indent should never use tabs #2869: FILE: include/hw/xen/interface/io/usbif.h:117: + * - operation flag:^Ibit 5$ ERROR: code indent should never use tabs #2870: FILE: include/hw/xen/interface/io/usbif.h:118: + *^I^I^I^I(0 = submit urb,$ ERROR: code indent should never use tabs #2871: FILE: include/hw/xen/interface/io/usbif.h:119: + *^I^I^I^I 1 = unlink urb)$ ERROR: code indent should never use tabs #2873: FILE: include/hw/xen/interface/io/usbif.h:121: + * - direction:^I^Ibit 7$ ERROR: code indent should never use tabs #2874: FILE: include/hw/xen/interface/io/usbif.h:122: + *^I^I^I^I(0 = Host-to-Device [Out]$ ERROR: code indent should never use tabs #2875: FILE: include/hw/xen/interface/io/usbif.h:123: + *^I^I^I^I 1 = Device-to-Host [In])$ ERROR: code indent should never use tabs #2877: FILE: include/hw/xen/interface/io/usbif.h:125: + * - device address:^Ibits 8-14$ ERROR: code indent should never use tabs #2879: FILE: include/hw/xen/interface/io/usbif.h:127: + * - endpoint:^I^Ibits 15-18$ ERROR: code indent should never use tabs #2881: FILE: include/hw/xen/interface/io/usbif.h:129: + * - pipe type:^Ibits 30-31$ ERROR: code indent should never use tabs #2882: FILE: include/hw/xen/interface/io/usbif.h:130: + *^I^I^I^I(00 = isochronous, 01 = interrupt,$ ERROR: code indent should never use tabs #2883: FILE: include/hw/xen/interface/io/usbif.h:131: + *^I^I^I^I 10 = control, 11 = bulk)$ ERROR: code indent should never use tabs #2886: FILE: include/hw/xen/interface/io/usbif.h:134: +#define USBIF_PIPE_PORT_MASK^I0x0000001f$ ERROR: code indent should never use tabs #2887: FILE: include/hw/xen/interface/io/usbif.h:135: +#define USBIF_PIPE_UNLINK^I0x00000020$ ERROR: code indent should never use tabs #2888: FILE: include/hw/xen/interface/io/usbif.h:136: +#define USBIF_PIPE_DIR^I^I0x00000080$ ERROR: code indent should never use tabs #2889: FILE: include/hw/xen/interface/io/usbif.h:137: +#define USBIF_PIPE_DEV_MASK^I0x0000007f$ ERROR: code indent should never use tabs #2890: FILE: include/hw/xen/interface/io/usbif.h:138: +#define USBIF_PIPE_DEV_SHIFT^I8$ ERROR: code indent should never use tabs #2891: FILE: include/hw/xen/interface/io/usbif.h:139: +#define USBIF_PIPE_EP_MASK^I0x0000000f$ ERROR: code indent should never use tabs #2892: FILE: include/hw/xen/interface/io/usbif.h:140: +#define USBIF_PIPE_EP_SHIFT^I15$ ERROR: code indent should never use tabs #2893: FILE: include/hw/xen/interface/io/usbif.h:141: +#define USBIF_PIPE_TYPE_MASK^I0x00000003$ ERROR: code indent should never use tabs #2894: FILE: include/hw/xen/interface/io/usbif.h:142: +#define USBIF_PIPE_TYPE_SHIFT^I30$ ERROR: code indent should never use tabs #2895: FILE: include/hw/xen/interface/io/usbif.h:143: +#define USBIF_PIPE_TYPE_ISOC^I0$ ERROR: code indent should never use tabs #2896: FILE: include/hw/xen/interface/io/usbif.h:144: +#define USBIF_PIPE_TYPE_INT^I1$ ERROR: code indent should never use tabs #2897: FILE: include/hw/xen/interface/io/usbif.h:145: +#define USBIF_PIPE_TYPE_CTRL^I2$ ERROR: code indent should never use tabs #2898: FILE: include/hw/xen/interface/io/usbif.h:146: +#define USBIF_PIPE_TYPE_BULK^I3$ ERROR: code indent should never use tabs #2900: FILE: include/hw/xen/interface/io/usbif.h:148: +#define usbif_pipeportnum(pipe)^I^I^I((pipe) & USBIF_PIPE_PORT_MASK)$ ERROR: code indent should never use tabs #2901: FILE: include/hw/xen/interface/io/usbif.h:149: +#define usbif_setportnum_pipe(pipe, portnum)^I((pipe) | (portnum))$ ERROR: code indent should never use tabs #2903: FILE: include/hw/xen/interface/io/usbif.h:151: +#define usbif_pipeunlink(pipe)^I^I^I((pipe) & USBIF_PIPE_UNLINK)$ ERROR: code indent should never use tabs #2904: FILE: include/hw/xen/interface/io/usbif.h:152: +#define usbif_pipesubmit(pipe)^I^I^I(!usbif_pipeunlink(pipe))$ ERROR: code indent should never use tabs #2905: FILE: include/hw/xen/interface/io/usbif.h:153: +#define usbif_setunlink_pipe(pipe)^I^I((pipe) | USBIF_PIPE_UNLINK)$ ERROR: code indent should never use tabs #2907: FILE: include/hw/xen/interface/io/usbif.h:155: +#define usbif_pipein(pipe)^I^I^I((pipe) & USBIF_PIPE_DIR)$ ERROR: code indent should never use tabs #2908: FILE: include/hw/xen/interface/io/usbif.h:156: +#define usbif_pipeout(pipe)^I^I^I(!usbif_pipein(pipe))$ ERROR: code indent should never use tabs #2910: FILE: include/hw/xen/interface/io/usbif.h:158: +#define usbif_pipedevice(pipe)^I^I^I\$ ERROR: code indent should never use tabs #2911: FILE: include/hw/xen/interface/io/usbif.h:159: +^I^I(((pipe) >> USBIF_PIPE_DEV_SHIFT) & USBIF_PIPE_DEV_MASK)$ ERROR: code indent should never use tabs #2913: FILE: include/hw/xen/interface/io/usbif.h:161: +#define usbif_pipeendpoint(pipe)^I^I\$ ERROR: code indent should never use tabs #2914: FILE: include/hw/xen/interface/io/usbif.h:162: +^I^I(((pipe) >> USBIF_PIPE_EP_SHIFT) & USBIF_PIPE_EP_MASK)$ ERROR: code indent should never use tabs #2916: FILE: include/hw/xen/interface/io/usbif.h:164: +#define usbif_pipetype(pipe)^I^I^I\$ ERROR: code indent should never use tabs #2917: FILE: include/hw/xen/interface/io/usbif.h:165: +^I^I(((pipe) >> USBIF_PIPE_TYPE_SHIFT) & USBIF_PIPE_TYPE_MASK)$ ERROR: code indent should never use tabs #2918: FILE: include/hw/xen/interface/io/usbif.h:166: +#define usbif_pipeisoc(pipe)^I(usbif_pipetype(pipe) == USBIF_PIPE_TYPE_ISOC)$ ERROR: code indent should never use tabs #2919: FILE: include/hw/xen/interface/io/usbif.h:167: +#define usbif_pipeint(pipe)^I(usbif_pipetype(pipe) == USBIF_PIPE_TYPE_INT)$ ERROR: code indent should never use tabs #2920: FILE: include/hw/xen/interface/io/usbif.h:168: +#define usbif_pipectrl(pipe)^I(usbif_pipetype(pipe) == USBIF_PIPE_TYPE_CTRL)$ ERROR: code indent should never use tabs #2921: FILE: include/hw/xen/interface/io/usbif.h:169: +#define usbif_pipebulk(pipe)^I(usbif_pipetype(pipe) == USBIF_PIPE_TYPE_BULK)$ ERROR: code indent should never use tabs #2924: FILE: include/hw/xen/interface/io/usbif.h:172: +#define USBIF_MAX_PORTNR^I31$ ERROR: code indent should never use tabs #2925: FILE: include/hw/xen/interface/io/usbif.h:173: +#define USBIF_RING_SIZE^I4096$ ERROR: code indent should never use tabs #2931: FILE: include/hw/xen/interface/io/usbif.h:179: +^Igrant_ref_t gref;$ ERROR: code indent should never use tabs #2932: FILE: include/hw/xen/interface/io/usbif.h:180: +^Iuint16_t offset;$ ERROR: code indent should never use tabs #2933: FILE: include/hw/xen/interface/io/usbif.h:181: +^Iuint16_t length;$ ERROR: code indent should never use tabs #2937: FILE: include/hw/xen/interface/io/usbif.h:185: +^Iuint16_t id; /* request id */$ ERROR: code indent should never use tabs #2938: FILE: include/hw/xen/interface/io/usbif.h:186: +^Iuint16_t nr_buffer_segs; /* number of urb->transfer_buffer segments */$ ERROR: code indent should never use tabs #2940: FILE: include/hw/xen/interface/io/usbif.h:188: +^I/* basic urb parameter */$ ERROR: code indent should never use tabs #2941: FILE: include/hw/xen/interface/io/usbif.h:189: +^Iuint32_t pipe;$ ERROR: code indent should never use tabs #2942: FILE: include/hw/xen/interface/io/usbif.h:190: +^Iuint16_t transfer_flags;$ ERROR: code indent should never use tabs #2943: FILE: include/hw/xen/interface/io/usbif.h:191: +#define USBIF_SHORT_NOT_OK^I0x0001$ ERROR: code indent should never use tabs #2944: FILE: include/hw/xen/interface/io/usbif.h:192: +^Iuint16_t buffer_length;$ ERROR: code indent should never use tabs #2945: FILE: include/hw/xen/interface/io/usbif.h:193: +^Iunion {$ ERROR: code indent should never use tabs #2946: FILE: include/hw/xen/interface/io/usbif.h:194: +^I^Iuint8_t ctrl[8]; /* setup_packet (Ctrl) */$ ERROR: code indent should never use tabs #2948: FILE: include/hw/xen/interface/io/usbif.h:196: +^I^Istruct {$ ERROR: code indent should never use tabs #2949: FILE: include/hw/xen/interface/io/usbif.h:197: +^I^I^Iuint16_t interval; /* maximum (1024*8) in usb core */$ ERROR: code indent should never use tabs #2950: FILE: include/hw/xen/interface/io/usbif.h:198: +^I^I^Iuint16_t start_frame; /* start frame */$ ERROR: code indent should never use tabs #2951: FILE: include/hw/xen/interface/io/usbif.h:199: +^I^I^Iuint16_t number_of_packets; /* number of ISO packet */$ ERROR: line over 90 characters #2952: FILE: include/hw/xen/interface/io/usbif.h:200: + uint16_t nr_frame_desc_segs; /* number of iso_frame_desc segments */ ERROR: code indent should never use tabs #2952: FILE: include/hw/xen/interface/io/usbif.h:200: +^I^I^Iuint16_t nr_frame_desc_segs; /* number of iso_frame_desc segments */$ ERROR: code indent should never use tabs #2953: FILE: include/hw/xen/interface/io/usbif.h:201: +^I^I} isoc;$ ERROR: code indent should never use tabs #2955: FILE: include/hw/xen/interface/io/usbif.h:203: +^I^Istruct {$ ERROR: code indent should never use tabs #2956: FILE: include/hw/xen/interface/io/usbif.h:204: +^I^I^Iuint16_t interval; /* maximum (1024*8) in usb core */$ ERROR: code indent should never use tabs #2957: FILE: include/hw/xen/interface/io/usbif.h:205: +^I^I^Iuint16_t pad[3];$ ERROR: code indent should never use tabs #2958: FILE: include/hw/xen/interface/io/usbif.h:206: +^I^I} intr;$ ERROR: code indent should never use tabs #2960: FILE: include/hw/xen/interface/io/usbif.h:208: +^I^Istruct {$ ERROR: code indent should never use tabs #2961: FILE: include/hw/xen/interface/io/usbif.h:209: +^I^I^Iuint16_t unlink_id; /* unlink request id */$ ERROR: code indent should never use tabs #2962: FILE: include/hw/xen/interface/io/usbif.h:210: +^I^I^Iuint16_t pad[3];$ ERROR: code indent should never use tabs #2963: FILE: include/hw/xen/interface/io/usbif.h:211: +^I^I} unlink;$ ERROR: code indent should never use tabs #2965: FILE: include/hw/xen/interface/io/usbif.h:213: +^I} u;$ ERROR: code indent should never use tabs #2967: FILE: include/hw/xen/interface/io/usbif.h:215: +^I/* urb data segments */$ ERROR: code indent should never use tabs #2968: FILE: include/hw/xen/interface/io/usbif.h:216: +^Istruct usbif_request_segment seg[USBIF_MAX_SEGMENTS_PER_REQUEST];$ ERROR: code indent should never use tabs #2973: FILE: include/hw/xen/interface/io/usbif.h:221: +^Iuint16_t id; /* request id */$ ERROR: code indent should never use tabs #2974: FILE: include/hw/xen/interface/io/usbif.h:222: +^Iuint16_t start_frame; /* start frame (ISO) */$ ERROR: code indent should never use tabs #2975: FILE: include/hw/xen/interface/io/usbif.h:223: +^Iint32_t status; /* status (non-ISO) */$ ERROR: code indent should never use tabs #2976: FILE: include/hw/xen/interface/io/usbif.h:224: +^Iint32_t actual_length; /* actual transfer length */$ ERROR: code indent should never use tabs #2977: FILE: include/hw/xen/interface/io/usbif.h:225: +^Iint32_t error_count; /* number of ISO errors */$ WARNING: line over 80 characters #2981: FILE: include/hw/xen/interface/io/usbif.h:229: +DEFINE_RING_TYPES(usbif_urb, struct usbif_urb_request, struct usbif_urb_response); ERROR: code indent should never use tabs #2988: FILE: include/hw/xen/interface/io/usbif.h:236: +^Iuint16_t id;$ ERROR: code indent should never use tabs #2993: FILE: include/hw/xen/interface/io/usbif.h:241: +^Iuint16_t id; /* request id */$ ERROR: code indent should never use tabs #2994: FILE: include/hw/xen/interface/io/usbif.h:242: +^Iuint8_t portnum; /* port number */$ ERROR: code indent should never use tabs #2995: FILE: include/hw/xen/interface/io/usbif.h:243: +^Iuint8_t speed; /* usb_device_speed */$ ERROR: code indent should never use tabs #2996: FILE: include/hw/xen/interface/io/usbif.h:244: +#define USBIF_SPEED_NONE^I0$ ERROR: code indent should never use tabs #2997: FILE: include/hw/xen/interface/io/usbif.h:245: +#define USBIF_SPEED_LOW^I^I1$ ERROR: code indent should never use tabs #2998: FILE: include/hw/xen/interface/io/usbif.h:246: +#define USBIF_SPEED_FULL^I2$ ERROR: code indent should never use tabs #2999: FILE: include/hw/xen/interface/io/usbif.h:247: +#define USBIF_SPEED_HIGH^I3$ WARNING: line over 80 characters #3003: FILE: include/hw/xen/interface/io/usbif.h:251: +DEFINE_RING_TYPES(usbif_conn, struct usbif_conn_request, struct usbif_conn_response); WARNING: Block comments use a leading /* on a separate line #3013: FILE: include/hw/xen/interface/io/xenbus.h:1: +/***************************************************************************** total: 117 errors, 21 warnings, 2967 lines checked Patch 2/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190621105441.3025-1-anthony.perard@xxxxxxxxxx/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@xxxxxxxxxx _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.