Re: [Xen-devel] [PATCH v2 02/10] xen: rename un/map_mmio_regions to un/map_regions

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 17/06/2019 22:24, Stefano Stabellini wrote:
> On Wed, 1 May 2019, Julien Grall wrote:
> > Hi,
> >
> > On 30/04/2019 22:02, Stefano Stabellini wrote:
> > > Now that map_mmio_regions takes a p2mt parameter, there is no need to
> > > keep "mmio" in the name. The p2mt parameter does a better job at
> > > expressing what the mapping is about. Let's save the environment 5
> > > characters at a time.
> > At least on Arm, what's the difference with guest_physmap_add_entry and this
> > function now? On x86, how does the user now which function to use?
> >
> > What actually tell the users it should not use this function for RAM?
> Also taking into account Jan's comments, I'll drop this patch in the
> next version, keeping the original name map_mmio_regions. If you have an
> alternative suggestion let me know and I'll try to follow it.
As long as only p2m_mmio_* types can be used here, then I am fine with it.

Compare to x86, the P2M interface on Arm is pretty much a wild west so far. I 
have a TODO to rethink and add more check in them on Arm.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel