Re: [Xen-devel] [PATCH v3 11/13] pci: switch pci_conf_write16 to use pci_sbdf_t

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.06.19 at 11:22, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/cpu/amd.c
> +++ b/xen/arch/x86/cpu/amd.c
> @@ -707,11 +707,11 @@ static void init_amd(struct cpuinfo_x86 *c)
>                                      (h & 0x1) ? "clearing D18F3x5C[0]" : "");
>  
>                       if (l & 0x1f)
> -                             pci_conf_write32(0, 0, 0x18, 0x3, 0x58,
> +                             pci_conf_write32(0, 0, 0x18, 3, 0x58,
>                                                l & ~0x1f);
>  
>                       if (h & 0x1)
> -                             pci_conf_write32(0, 0, 0x18, 0x3, 0x5c,
> +                             pci_conf_write32(0, 0, 0x18, 3, 0x5c,
>                                                h & ~0x1);
>               }

These changes don't seem to belong here. With this taken care of
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel