Re: [Xen-devel] [PATCH] xen/arm: io: add function swap_mmio_handler()

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 6/12/19 6:42 AM, Baodong Chen wrote:
> Swap function can be used when calling sort().
> or else, the default swap function generic_swap() is used,
> which is a little inefficient.
I am not entirely convince this will be more efficient. mmio_handler 
does not fit in 64 bit, so the compiler may decide to do either multiple 
load or replace with a memcpy.
So at best this feels some micro-optimization. But then, this is only 
call a limited number of time at each domain build. Is it really worth it?
On a side note, I have noticed you are sending a lot of 
optimization/clean-up patch. What is your end goal here?
If it is to improve the performance, then there are much bigger fish to 
fry within Xen code base. I am happy to point some of them based on 
where you are looking to improve.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel