Re: [Xen-devel] [PATCH MM-PART3 v2 01/12] xen/arm: lpae: Add a macro to generate offsets from an address

[Julien Grall <Julien.Grall@xxxxxxx>]

Hi Stefano,

On 11/06/2019 19:21, Stefano Stabellini wrote:
> On Tue, 14 May 2019, Julien Grall wrote:
>> There are few places requiring to generate offsets from an address.
>> Rather than open-coding everywhere, we can introduce a macro to do the
>> job for us.
>>
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
>> Reviewed-by: Andrii Anisov <andrii_anisov@xxxxxxxx>
>>
>> ---
>>      Changes in v2:
>>          - Add Andrii's reviewed-by
>> ---
>>   xen/arch/arm/p2m.c         | 23 +++--------------------
>>   xen/include/asm-arm/lpae.h |  9 +++++++++
>>   2 files changed, 12 insertions(+), 20 deletions(-)
>>
>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
>> index 92c2413f20..06fa342a8f 100644
>> --- a/xen/arch/arm/p2m.c
>> +++ b/xen/arch/arm/p2m.c
>> @@ -368,12 +368,7 @@ mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn,
>>       p2m_type_t _t;
>>   
>>       /* Convenience aliases */
> 
> I don't know if you want to keep this comment, we could get rid of it.

It is probably useless now. I will drop it along with the newline on top.

> Either way:
> 
> Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

Thank you!

Cheers,

-- 
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel