Re: [Xen-devel] [PATCH] xen: superficial clean-ups

[chenbaodong <chenbaodong@xxxxxxxxxx>]

On 6/11/19 17:45, Andrew Cooper wrote:
> On 11/06/2019 10:20, Baodong Chen wrote:
> > * Remove redundant set 'DOMDYING_dead'
> > domain_create() will set this when fail, thus no need
> > set in arch_domain_create().
> Its not redundant.  It is necessary for correct cleanup.
Hello Andrew,

Thanks for your comments.

Your concern is: when the arch_domain_create() fails,

some cleanup work need to done in this function.

and 'DOMDYING_dead' flags maybe needed to judge for correct cleanup?

If so, it's not redundant.

I'm curious  why 'DOMDYING_dead' been set by fail path both in 
arch_domain_create()
and domain_create().

> All of this logic will be rewritten when the destroy paths are fully
> idempotent, and while ARM is fairing well in this regard, the common and
> x86 needs more work.
>
> ~Andrew
>
> .
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel