Re: [Xen-devel] [PATCH] xen/arm: domain: remove redundant memset for arch's saved_context when creating vcpu

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

Thank you for the patch. The title should be at max 80 characters. So 
how about the following title?
"xen/arm: domain: Remove redundant memset for v->arch.saved_context"

On 6/10/19 6:15 AM, Baodong Chen wrote:
> Already done by clear_page() in alloc_vcpu_struct()
Please try to make sentence in the commit message. For here I would suggest:

"v->arch.saved_context is already zeroed in alloc_vcpu_struct() by 
clear_page(). So there are no need to memset it again in 
arch_vcpu_create()."
If you are happy with the two changes, I can do them on commit.

Cheers,

> Signed-off-by: Baodong Chen <chenbaodong@xxxxxxxxxx>
> ---
>   xen/arch/arm/domain.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index ff330b3..ad1b106 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -557,7 +557,6 @@ int arch_vcpu_create(struct vcpu *v)
>                                              - sizeof(struct cpu_info));
>       memset(v->arch.cpu_info, 0, sizeof(*v->arch.cpu_info));
>   
> -    memset(&v->arch.saved_context, 0, sizeof(v->arch.saved_context));
>       v->arch.saved_context.sp = (register_t)v->arch.cpu_info;
>       v->arch.saved_context.pc = (register_t)continue_new_vcpu;
>   
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel