Re: [Xen-devel] [PATCH MM-PART2 RESEND v2 17/19] xen/arm: mm: Initialize page-tables earlier

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 05/06/2019 00:12, Stefano Stabellini wrote:
> On Tue, 14 May 2019, Julien Grall wrote:
> > Since commit f60658c6ae "xen/arm: Stop relocating Xen", the function
> > setup_page_tables() does not require any information from the FDT.
> >
> > So the initialization of the page-tables can be done much earlier in the
> > boot process. The earliest setup_page_tables() can be called is after
> > traps have been initialized, so we can get backtrace if an error
> > occurred.
> >
> > Moving the initialization of the page-tables also avoid the dance to map
> > the FDT again in the new set of page-tables.
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> > Reviewed-by: Andrii Anisov <andrii_anisov@xxxxxxxx>
> >
> > ---
> >      Changes in v2:
> >          - Add Andrii's reviewed-by
> > ---
> >   xen/arch/arm/mm.c    | 12 +++---------
> >   xen/arch/arm/setup.c |  4 ++--
> >   2 files changed, 5 insertions(+), 11 deletions(-)
> >
> > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> > index 7502a14760..eacc1647e0 100644
> > --- a/xen/arch/arm/mm.c
> > +++ b/xen/arch/arm/mm.c
> > @@ -550,7 +550,7 @@ static inline lpae_t pte_of_xenaddr(vaddr_t va)
> >       return mfn_to_xen_entry(maddr_to_mfn(ma), MT_NORMAL);
> >   }
> >   
> > -/* Map the FDT in the early boot page table */
> > +/* Map the FDT in the runtime page table */
> I think you can drop this comment now.
Good point, the more the plan is to have only one set of page-tables.

> In any case:
>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Thank you for the review!

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel