Re: [Xen-devel] [PATCH v5 01/10] xen/arm: add generic TEE mediator framework

[Julien Grall <julien.grall@xxxxxxx>]

Hi Volodymyr,

On 5/21/19 10:25 PM, Volodymyr Babchuk wrote:
> +static inline bool tee_handle_call(struct cpu_user_regs *regs)
> +{
> +    return false;
> +}
> +
> +static inline int tee_domain_init(struct domain *d, uint16_t tee_type)
> +{
> +    return -ENODEV;
> +}
I had a report that Xen fails to boot with this series and !CONFIG_TEE. 
This is because you return an error here in all the case some domain 
creation will always fail.
Instead this should check that tee_type is always NONE or else return an 
error.
Also, please at least check that your series does not break boot when 
CONFIG_TEE is not selected. It would also be ideal (but not mandatory) 
if you can check that it does not break on non-OPTEE platform when 
!CONFIG_TEE is selected.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel