[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v1] xen: make tracebuffer configurable
- To: Jan Beulich <JBeulich@xxxxxxxx>, <george.dunlap@xxxxxxxxxx>
- From: chenbaodong <chenbaodong@xxxxxxxxxx>
- Date: Wed, 5 Jun 2019 09:28:28 +0800
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, IanJackson <Ian.Jackson@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 05 Jun 2019 01:28:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 6/4/19 19:43, Jan Beulich wrote:
On 04.06.19 at 12:49, <George.Dunlap@xxxxxxxxxx> wrote:
On Jun 4, 2019, at 1:44 AM, Baodong Chen <chenbaodong@xxxxxxxxxx> wrote:
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -368,4 +368,16 @@ config DOM0_MEM
Leave empty if you are not sure what to specify.
+config TRACEBUFFER
+ bool "Enable trace event logs" if EXPERT = "y"
+ ---help---
+ Xen internal running status(trace event) will be saved to trace memory
+ when enabled. trace event data and config params can be read/changed
+ by system control hypercall at run time.
+
+ This is used to record xen internal running status.
+ with a litte performance overhead.
+ Can be set to 'N' if you dont want this function.
+ When not configured, 'XEN_STSCTL_tbuf_op' command will result
'ENOSYS’.
I think this would look better something like this:
“Enable tracing infrastructure”
“Enable in tracing infrastructure and pre-defined tracepoints within Xen.
This will allow live information about Xen’s execution and performance to be
collected at run time for debugging or performance analysis. Memory and
execution overhead when not active is minimal."
Also, I’m not 100% familiar with the kconfig syntax — I think we want
tracing enabled by default unless actively disabled; is that what will happen
here? Or will it only be enabled if EXPERT == ‘y’?
Oh, indeed - there's a "default y" missing.
Thanks for suggestion for the help text. and pointing out "default y"
missing.
Fixed in v3 and please discard v2.
Jan
.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
