Re: [Xen-devel] [PATCH v3 1/3] xen/arm: fix nr_pdxs calculation

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 6/3/19 11:02 PM, Stefano Stabellini wrote:
> pfn_to_pdx expects an address, not a size, as a parameter. Specifically,
> it expects the end address, then the masks calculations compensate for
> any holes between start and end. Thus, we should pass the end address to
> pfn_to_pdx.
>
> The initial pdx is stored in frametable_base_pdx, so we can subtract the
> result of pfn_to_pdx(start_address) from nr_pdxs; we know that we don't
> need to cover any memory in the range 0-start in the frametable.
>
> Remove the variable `nr_pages' because it is unused.
>
> Signed-off-by: Stefano Stabellini <stefanos@xxxxxxxxxx>
Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel