Re: [Xen-devel] [PATCH] AMD/IOMMU: revert "amd/iommu: assign iommu devices to Xen"

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.06.19 at 11:04, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 03/06/2019 14:00, Jan Beulich wrote:
>> This reverts commit b6bd02b7a877f9fac2de69e64d8245d56f92ab25. The change
>> was redundant with amd_iommu_detect_one_acpi() already calling
>> pci_ro_device().
> 
> Seeing as amd_iommu_detect_one_acpi() hasn't changed for many years, and
> b6bd02b7 was a functional fix for booting PVH on AMD, I can't see what
> would make this true now.

Just as a side note - amd_iommu_detect_one_acpi() now gets called
quite a bit earlier afaict. Yet I don't think this makes a difference here.
Nevertheless, as things stand the commit I'm suggesting to revert
can at best have papered over an issue elsewhere. Unless I'm missing
something.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel