Re: [Xen-devel] [PATCH 2/2] dom_cow is needed for mem-sharing only

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.06.19 at 02:40, <tamas@xxxxxxxxxxxxx> wrote:
> On Fri, May 31, 2019 at 3:35 AM Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>
>> A couple of adjustments are needed to code checking for dom_cow, but
>> since there are pretty few it is probably better to adjust those than
>> to set up and keep around a never used domain.
>>
>> Take the opportunity and tighten a BUG_ON() in emul-priv-op.c:read_cr().
>> (Arguably this perhaps shouldn't be a BUG_ON() in the first place.)
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> While for now this avoids creating the domain on Arm only, Tamas'es
>> patch switching to CONFIG_MEM_SHARING will make x86 leverage this too.
> 
> perhaps it would be better to have this patch be applied after my
> patch? You already acked that one and it could be applied separately
> from the series that I've sent it as part of.

Oh, I didn't realize it is entirely independent of the earlier patches.
It would help to point such out in the cover letter, requiring there
to be one in the first place.

Yet even then - it's lacking an XSM maintainer ack afaics (and it
looks as if you didn't even Cc Daniel), and I'd prefer a patch like
this to also have an ack from George, even if judging by the files
touched this may not be strictly required.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel