Re: [Xen-devel] [PATCH v2] Add TRACKING.IMPORTS to xen.git to more easily manage imported files that need to be kept in sync with an upstream

[Lars Kurth <lars.kurth@xxxxxxxxxx>]

On 24/05/2019, 05:24, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

    >>> On 24.05.19 at 03:36, <lars.kurth@xxxxxxxxxx> wrote:
    > --- /dev/null
    > +++ b/TRACKING.FILES
    > @@ -0,0 +1,50 @@
    > +# This file contains information about source files that have been
    > +# copied from other sources and need to be tracked
    > +#
    > +# The file may contain lines starting with ...
    > +# --------------------------------------------
    > +# version: of file format
    > +# repo: repository definition
    > +# file: a mapping to track files
    > +#
    > +# Note that repo: entries must come *before* file: entries
    > +#
    > +# Repository Definitions are of the following format
    > +# --------------------------------------------------
    > +# repo: name-of-source-repo git|svn https-url-of-source-repo
    > +#
    > +# name-of-source-repo:
    > +#   Name of source repository. The name will be used as reference in 
file:
    > +#   statements
    
    May I suggest another formatting change, as the colon uses now
    have different meaning:
    
    # repo: <name-of-source-repo> <type-of-source-repo> <url-of-source-repo>
    #
    # <name-of-source-repo>
    #   Name of source repository. The name will be used as reference in file:
    #   statements
    
    > +# git|svn:
    > +#   Type ofsource repository
    
    Nit: Missing blank.
    
    > +# https-url-of-source-repo:
    > +#   URL of source repository
    
    Why https? Any form of URL should be fine here.
    
Sure. I think Ian suggested originally.

    > +# For example:
    > +#   repo: linux-torvalds git 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
    
    Didn't we agree on examples moving into the commit message,
    or the post-commit-message area, as they'll become redundant
    (and eventually stale) once we gain actual content here?
    
Ah yes, I had forgotten about this

Lars    
    
    

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel