Re: [Xen-devel] [PATCH 2/3] xen/drivers/char: Don't require vpl011 for all non-x86 archs

[Julien Grall <julien.grall@xxxxxxx>]

On 16/05/2019 20:30, Alistair Francis wrote:
> On Thu, May 16, 2019 at 3:32 AM Jan Beulich <JBeulich@xxxxxxxx> wrote:
> > > > > On 16.05.19 at 02:02, <alistair.francis@xxxxxxx> wrote:
> > > Make the asm/vpl011.h dependent on the ARM architecture.
> > But we only have x86 and Arm right now. A word more about
> > your motivation would help.
> As the code currently is no one can add another architecture. This is
> just a general fixup as assuming Xen will only ever support two archs
> seems strange.
At which point, wouldn't it be better to avoid #ifdef ARCH in common code? 
Instead, we could provide arch helper and/or more meaning CONFIG name.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel