Re: [Xen-devel] [patch 2/2] xen/arm: Use p2m entry with lock protection

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 30 Apr 2019, Hillf Danton wrote:
> A new local variable is introduced for accessing p2m entry with lock 
> protection.
> 

Same comment about html and space damage. But the change looks correct.


> 
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> 
> Signed-off-by: Hillf Danton <hdanton@xxxxxxxx>
> 
> ---
> 
>  
> 
> --- a/arch/arm/xen/p2m.c 2019-04-30 12:32:05.363768200 +0800
> 
> +++ b/arch/arm/xen/p2m.c    2019-04-30 12:58:19.854334100 +0800
> 
> @@ -70,8 +70,9 @@ unsigned long __pfn_to_mfn(unsigned long
> 
>              entry = rb_entry(n, struct xen_p2m_entry, rbnode_phys);
> 
>              if (entry->pfn <= pfn &&
> 
>                            entry->pfn + entry->nr_pages > pfn) {
> 
> +                  unsigned long mfn = entry->mfn + (pfn - entry->pfn);
> 
>                     read_unlock_irqrestore(&p2m_lock, irqflags);
> 
> -                  return entry->mfn + (pfn - entry->pfn);
> 
> +                  return mfn;
> 
>              }
> 
>              if (pfn < entry->pfn)
> 
>                     n = n->rb_left;
> 
> --
> 
>  
> 
> 
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel