Re: [Xen-devel] [PATCH] timers: limit heap size

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.04.19 at 16:18, <wei.liu2@xxxxxxxxxx> wrote:
> On Tue, Apr 09, 2019 at 07:01:55AM -0600, Jan Beulich wrote:
>> @@ -544,7 +549,7 @@ static void dump_timerq(unsigned char ke
>>      struct timers *ts;
>>      unsigned long  flags;
>>      s_time_t       now = NOW();
>> -    int            i, j;
>> +    unsigned int   i, j;
> 
> A further possible improvement is to move j within the scope of
> for_each_online_cpu {}.

In fact I did consider this, but decided against: It's "just" a
debugging function, and j is not the only variable that would
better move into the more narrow scope. Moving them all is
beyond the scope of this patch, though.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel