[Xen-devel] [PATCH] xen/tools: Fix symbols segfaults

[Pawel Wieczorkiewicz <wipawel@xxxxxxxxx>]

The symbols tool is outdated and has a bug in it leading to crashes.
The tool is derived from linux kernel where this bug has been already
fixed.

Original linux kernel commit:
e0a04b11e4059cab033469617 scripts/kallsyms.c: fix potential segfault

Signed-off-by: Pawel Wieczorkiewicz <wipawel@xxxxxxxxx>
Reviewed-by: Bjoern Doebel <doebel@xxxxxxxxx>
Reviewed-by: Norbert Manthey <nmanthey@xxxxxxxxx>
---
 xen/tools/symbols.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/tools/symbols.c b/xen/tools/symbols.c
index 8c5842d43f..05139d1600 100644
--- a/xen/tools/symbols.c
+++ b/xen/tools/symbols.c
@@ -525,6 +525,8 @@ static void optimize_result(void)
 
                        /* find the token with the breates profit value */
                        best = find_best_token();
+                       if (token_profit[best] == 0)
+                               break;
 
                        /* place it in the "best" table */
                        best_table_len[i] = 2;
-- 
2.16.5




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrer: Christian Schlaeger, Ralf Herbrich
Ust-ID: DE 289 237 879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel