Re: [Xen-devel] [PATCH v2 1/1] hvmloader: add SMBIOS type 2 info for customized string

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.03.19 at 04:28, <talons.lee@xxxxxxxxx> wrote:
> Extend smbios type 2 struct to match specification, add support to
> write it when customized string provided and no smbios passed in.
> 
> Signed-off-by: Xin Li <xin.li@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
> CC: Sergey Dyasli <sergey.dyasli@xxxxxxxxxx>
> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> v2
> 1: write the struct if any of the strings is provided
> 2: add contained_handles as flexible array member
> 3: update commit message and fix style issue

So this is the 3rd variant of v2 that you've sent, without making it clear
what the difference is. I suppose you've addressed my one remaining
cosmetic request and added my R-b, but we should be at v4 then.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel