Re: [Xen-devel] python3 issues

[M A Young <m.a.young@xxxxxxxxxxxx>]

On Tue, 26 Mar 2019, Wei Liu wrote:

> On Tue, Mar 26, 2019 at 01:16:35PM +0000, Wei Liu wrote:
> > On Mon, Mar 25, 2019 at 10:20:05PM +0000, YOUNG, MICHAEL A. wrote:
> > >          if ty.init_fn is not None:
> > > --- xen-4.12.0-rc6/tools/pygrub/src/GrubConf.py.orig      2019-03-24 
> > > 22:44:05.502581989 +0000
> > > +++ xen-4.12.0-rc6/tools/pygrub/src/GrubConf.py   2019-03-24 
> > > 22:49:14.025934786 +0000
> > > @@ -230,10 +230,10 @@
> > >      def _get_default(self):
> > >          return self._default
> > >      def _set_default(self, val):
> > > -        if val == "saved":
> > > +        if val == "saved" or not val.isdecimal():
> 
> Your change suggested there could be a non-decimal string that is not
> "saved" -- is this really needed?

It is getting set to ${next_entry} presumably from the clause 

if [ "${next_entry}" ] ; then
   set default="${next_entry}"
   set next_entry=
   save_env next_entry
   set boot_once=true
else
   set default="${saved_entry}"
fi

in the grub.cfg file giving the error

  File "/usr/lib64/python3.7/site-packages/grub/GrubConf.py", line 239, in 
_set_default
    if self._default < 0:
TypeError: '<' not supported between instances of 'str' and 'int'

I didn't see this with python 2 before the patch so I assume python3 is 
more fussy.

        Michael Young

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel