Re: [Xen-devel] [PATCH v1 1/4] xen: add hypercall for getting parameters at runtime

[Vasilis Liaskovitis <vliaskovitis@xxxxxxxx>]

On Mon, 2019-03-18 at 18:01 +0100, Jan Beulich wrote:
> > > > An alternative prototype could be:
> > > >             int (*get_func)(char *output);
> > > > if we want the function to write the current parameter value
> > > > into a
> > > > caller-provided buffer, and possibly return error codes.
> > > 
> > > And how would the callee know how much space there is?
> > 
> > yes, an extra size argument would be needed from the caller here.
> > 
> > Let me know if either of these or a different approach is
> > preferred.
> 
> Of the two, I clearly prefer the latter. Then again me having pointed
> out the shortcoming doesn't mean we (and hence you for this patch)
> absolutely have to deal with custom parameters. 

Unless there are objections, I think 'll send a v2 about getting non-
custom parameter types first, and deal with custom parameters in a
separate future patchset.

thanks,

- Vasilis


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel