Re: [Xen-devel] [PATCH] libxc: fix HVM core dump

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Wei Liu writes ("[PATCH] libxc: fix HVM core dump"):
> f969bc9fc96 forbid get_address_size call on HVM guests, because that
> didn't make sense. It broke core dump functionality on HVM because
> libxc unconditionally asked for guest width.
...
> +    if ( !auto_translated_physmap &&
> +         xc_domain_get_guest_width(xch, domid, &dinfo->guest_width) != 0 )
> +    {
> +        PERROR("Could not get address size for domain");
> +        goto out;
> +    }

Did you consider and reject the option of writing:

    if ( auto_translated_physmap ) {
         ... xc_domain_get_guest_width(,,&dinfo->guest_width,,) ...
    } else {
         dinfo->guest_width = sizeof(unsigned long)
    }

This is perhaps less likely to leave dinfo->guest_width as an
uninitialised hazard.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel