Re: [Xen-devel] [PATCH RESEND 2/3] OvmfPkg/XenSupport: use a correct PCI host bridge aperture for BAR64

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Wed, Mar 06, 2019 at 12:40:55PM +0000, Igor Druzhinin wrote:
> In case BAR64 is placed below 4G choose the correct aperture.
> This fixes a failed assertion down the code path.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
> ---
>  OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c 
> b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c
> index c23c46d..408fb24 100644
> --- a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c
> +++ b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c
> @@ -145,7 +145,11 @@ PcatPciRootBridgeParseBars (
>            Length = Length | LShiftU64 ((UINT64) UpperValue, 32);
>            Length = (~Length) + 1;
>  
> -          MemAperture = MemAbove4G;
> +          if (Base < 0x100000000) {

You could use the macro BASE_4GB to replace this 1 followed by a looong
list of 0.

And with that changed:
Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel