Re: [Xen-devel] [PATCH 1/6] x86/vtd: Don't include control register state in the table pointers

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Andrew Cooper [mailto:andrew.cooper3@xxxxxxxxxx]
> Sent: Saturday, February 23, 2019 3:13 AM
> 
> iremap_maddr and qinval_maddr point to the base of a block of contiguous
> RAM,
> allocated by the driver, holding the Interrupt Remapping table, and the
> Queued
> Invalidation ring.
> 
> Despite their name, they are actually the values of the hardware register,
> including control metadata in the lower 12 bits.  While uses of these fields
> do appear to correctly shift out the metadata, this is very subtle behaviour
> and confusing to follow.
> 
> Nothing uses the metadata, so make the fields actually point at the base of
> the relevant tables.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Good catch!

Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel